Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acm:GetCertificate to policy to provision resources for publish-egress-ip Lambda #143

Merged
merged 1 commit into from
May 6, 2024

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented May 6, 2024

🗣 Description

This PR adds the acm:GetCertificate permission to the policy used to provision resources for the publish-egress-ip Lambda.

💭 Motivation and context

Previously, this permission was not required in order to successfully apply cisagov/publish-egress-ip-terraform, but now it is.

🧪 Testing

I was able to successfully apply this Terraform. I confirmed that the new permission functioned as intended, because I was then able to successfully apply the Terraform in cisagov/publish-egress-ip-terraform.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label May 6, 2024
@dav3r dav3r self-assigned this May 6, 2024
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@dav3r dav3r merged commit f4eb26d into develop May 6, 2024
5 checks passed
@dav3r dav3r deleted the improvement/add-acm-permission branch May 6, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants