Remove reference to removed VersionCheckFile

[twneale]

Fix Version Check Path Bug

The version check code has a reference to a removed variable still present. This PR deletes it and closes #1480

🗣 Description

Deleted two lines of code writing out the version check file, which was removed for Kraken.

💭 Motivation and context

Currently this bug causes a error and stack trace on import.
Closes #1480

🧪 Testing

# Download 1.3
Invoke-WebRequest -Uri "https://github.com/cisagov/ScubaGear/releases/download/v1.3.0/ScubaGear-1.3.0.zip" -Outfile scuba-1.3.0.zip
Expand-Archive -Path "scuba-1.3.0.zip" -DestinationPath "scuba-1.3.0"

# Copy the check versions script over.
Copy-Item -Path "{path to git checkout}\Powershell\ScubaGear\CheckVersion.ps1" -Destination "scuba-1.3.0\Powershell\ScubaGear\CheckVersion.ps1"

# Finally, open Powershell\ScubaGear\ScubaGear.psd1 and add the CheckVersion.ps1 script to the ScriptsToProcess array. 

# Import scuba and view the warning.
Import-Module "scuba-1.3.0\Powershell\ScubaGear\CheckVersion.ps1"

Alternatively, you can just decrement the ModuleVersion in the scuba manifest and import from the git branch to view the warning.

✅ Pre-approval checklist

• This PR has an informative and human-readable title.
• PR targets the correct parent branch (e.g., main or release-name) for merge.
• Changes are limited to a single goal - eschew scope creep!
• Changes are sized such that they do not touch excessive number of files.
• All future TODOs are captured in issues, which are referenced in code comments.
• These code changes follow the ScubaGear content style guide.
• Related issues these changes resolve are linked preferably via closing keywords.
• All relevant type-of-change labels added.
• All relevant project fields are set.
• All relevant repo and/or project documentation updated to reflect these changes.
• Unit tests added/updated to cover PowerShell and Rego changes.
• Functional tests added/updated to cover PowerShell and Rego changes.
• All relevant functional tests passed.
• All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

• PR passed smoke test check.

• Feature branch has been rebased against changes from parent branch, as needed

  Use Rebase branch button below or use this reference to rebase from the command line.

• Resolved all merge conflicts on branch

• Notified merge coordinator that PR is ready for merge via comment mention

• Demonstrate changes to the team for questions and comments.
  (Note: Only required for issues of size Medium or larger)

✅ Post-merge checklist

• Feature branch deleted after merge to clean up repository.
• Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

[schrolla]

@twneale Testing section should also include how the reviewers can test the code. Also, have you tested it when running from the ZIP to see if it's fully resolved there too?

[schrolla]

The removal of the test code is perfect. But while reviewing I had some other suggestions and a possible bug that requires more extensive changes. See comments below.

[twneale]

@schrolla what would you think about checking PSGallery and comparing it to the module manifest version of the running ScubaGear rather than querying the installed versions and getting the latest? This way it would still work when running as a git checkout. Otherwise, running from a latest git checkout can result in an inaccurate warning to "upgrade" to a lower version. Instead of trying to guess whether it was installed from PSGallery or a GitHub zip, we could just warn that newer releases are available from both PSGallery and Github. Watcha think?

[schrolla]

@schrolla what would you think about checking PSGallery and comparing it to the module manifest version of the running ScubaGear rather than querying the installed versions and getting the latest? This way it would still work when running as a git checkout. Otherwise, running from a latest git checkout can result in an inaccurate warning to "upgrade" to a lower version. Instead of trying to guess whether it was installed from PSGallery or a GitHub zip, we could just warn that newer releases are available from both PSGallery and Github. Watcha think?

Yes, I think that's a reasonable way of checking since checking the manifest based on the PSScriptRoot of the running version check script makes it a direct comparison between the published available version and the running version. Whether you check GitHub or PSGallery for the comparison it doesn't much matter as they should be the same and are both official. I'd slightly prefer checking GitHub as that's the official release and PSGallery is just our package distribution mechanism which could (although not likely for now) change over time.

[twneale]

@schrolla I made that change and the code is short and sweet now. I added instructions for testing it out. I think it may be ready to rip now.

[schrolla]

See minor typo and wording suggestions and one possible TODO follow-on issue.

[schrolla]

Typo and capitalization fix

Suggested change

	Checks latest version available on the github release page and compares it to the current running verison.
	Checks latest version available on the Github release page and compares it to the current running version.

[schrolla]

The latest version may be comparatively newer without being new. Suggest updating language.

Suggested change

	Write-Warning "A new version of ScubaGear ($latestVersion) is available. Please consider updating at: https://github.com/cisagov/ScubaGear/releases. This notification can be disabled by setting `$env:SCUBAGEAR_SKIP_VERSION_CHECK = `$true before running ScubaGear."
	Write-Warning "A newer version of ScubaGear ($latestVersion) is available. Please consider updating at: https://github.com/cisagov/ScubaGear/releases. This notification can be disabled by setting `$env:SCUBAGEAR_SKIP_VERSION_CHECK = `$true before running ScubaGear."

[schrolla]

Thinking about where we point them when a new version is available. Do we point directly to the GitHub release, or to our documentation? PSGallery users won't get much from the GitHub link.
We have install instructions, but not specifically upgrade instructions. Might be a good section to add and maintain in case we run into any difficult/breaking change upgrade paths. Already an issue in #1223. So maybe add to that issue that once instructions are available, update version update function to point to them instead.