ruby: Update dependency rugged to version 1.6.3 #9158
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running
bundle install
on my machine fails because there is compilation error for rugged. Details collapsed below:Rugged compilation output
-- Disabled features:
-- Configuring done (8.7s)
-- Generating done (0.1s)
-- Build files have been written to: /Users/Marcos/.rbenv/versions/3.1.3/lib/ruby/gems/3.1.0/gems/rugged-1.0.1/vendor/libgit2/build
-- /usr/bin/make
checking for -lgit2... yes
checking for git2.h... yes
creating Makefile
current directory: /Users/Marcos/.rbenv/versions/3.1.3/lib/ruby/gems/3.1.0/gems/rugged-1.0.1/ext/rugged
make DESTDIR= sitearchdir=./.gem.20241220-26548-t2qaxr sitelibdir=./.gem.20241220-26548-t2qaxr clean
current directory: /Users/Marcos/.rbenv/versions/3.1.3/lib/ruby/gems/3.1.0/gems/rugged-1.0.1/ext/rugged
make DESTDIR= sitearchdir=./.gem.20241220-26548-t2qaxr sitelibdir=./.gem.20241220-26548-t2qaxr
compiling rugged.c
rugged.c:296:2: warning: 'rb_iterate' is deprecated: by: rb_block_call since 1.9 [-Wdeprecated-declarations]
rb_iterate(rb_each, rb_enum, &minimize_cb, (VALUE)shrt);
^
/Users/Marcos/.rbenv/versions/3.1.3/include/ruby-3.1.0/ruby/internal/iterator.h:269:1: note: 'rb_iterate' has been explicitly marked deprecated here
RBIMPL_ATTR_DEPRECATED(("by: rb_block_call since 1.9"))
^
/Users/Marcos/.rbenv/versions/3.1.3/include/ruby-3.1.0/ruby/internal/attr/deprecated.h:36:53: note: expanded from macro 'RBIMPL_ATTR_DEPRECATED'
define RBIMPL_ATTR_DEPRECATED(msg) attribute((deprecated msg))
rugged.c:296:31: error: incompatible function pointer types passing 'VALUE (*)(VALUE, git_oid_shorten )' (aka 'unsigned long ()(unsigned long, struct git_oid_shorten )') to parameter of type 'rb_block_call_func_t' (aka 'unsigned long ()(unsigned long, unsigned long, int, const unsigned long *, unsigned long)') [-Wincompatible-function-pointer-types]
rb_iterate(rb_each, rb_enum, &minimize_cb, (VALUE)shrt);
^~~~~~~~~~~~
/Users/Marcos/.rbenv/versions/3.1.3/include/ruby-3.1.0/ruby/internal/iterator.h:283:75: note: passing argument to parameter 'proc' here
VALUE rb_iterate(VALUE (*func1)(VALUE), VALUE data1, rb_block_call_func_t proc, VALUE data2);
^
rugged.c:308:3: warning: 'rb_iterate' is deprecated: by: rb_block_call since 1.9 [-Wdeprecated-declarations]
rb_iterate(rb_each, rb_enum, &minimize_yield, (VALUE)yield_data);
^
/Users/Marcos/.rbenv/versions/3.1.3/include/ruby-3.1.0/ruby/internal/iterator.h:269:1: note: 'rb_iterate' has been explicitly marked deprecated here
RBIMPL_ATTR_DEPRECATED(("by: rb_block_call since 1.9"))
^
/Users/Marcos/.rbenv/versions/3.1.3/include/ruby-3.1.0/ruby/internal/attr/deprecated.h:36:53: note: expanded from macro 'RBIMPL_ATTR_DEPRECATED'
define RBIMPL_ATTR_DEPRECATED(msg) attribute((deprecated msg))
rugged.c:308:32: error: incompatible function pointer types passing 'VALUE (*)(VALUE, VALUE )' (aka 'unsigned long ()(unsigned long, unsigned long )') to parameter of type 'rb_block_call_func_t' (aka 'unsigned long ()(unsigned long, unsigned long, int, const unsigned long *, unsigned long)') [-Wincompatible-function-pointer-types]
rb_iterate(rb_each, rb_enum, &minimize_yield, (VALUE)yield_data);
^~~~~~~~~~~~~~~
/Users/Marcos/.rbenv/versions/3.1.3/include/ruby-3.1.0/ruby/internal/iterator.h:283:75: note: passing argument to parameter 'proc' here
VALUE rb_iterate(VALUE (*func1)(VALUE), VALUE data1, rb_block_call_func_t proc, VALUE data2);
^
2 warnings and 2 errors generated.
make: *** [rugged.o] Error 1
make failed, exit code 2
For reference, see prontolabs/pronto#447.