Use deploy scripts from xpadneo #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project xpadneo (https://github.com/atar-axis/xpadneo) has some great DKMS helper scripts. It seems as if these are a better replacement for our `deploy.sk` script. This commit only adds the scripts almost unaltered. The only changes are to adapt the import directory and to add a license header.
This is required in order to make the new installation scripts work out.
I am not sure whether that makes sense at all or whether one could use "88x2bu" throughout. I stick with the status quo for the moment.
The former works. The latter fails to unload the driver module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I had the joy of using the driver of https://github.com/atar-axis/xpadneo/. I found their deployment scripts a charm to work with. Not only were they quite robust, they also cover a usecase that is missing from
deploy.sh: uninstallation.Unfortunately, using these scripts would mean to move most of the repository in subfolder. Also the scripts itself might cause objections. Therefore I suggest them as a PR so we can discuss this change.
NOTE: The PR is not yet complete and should not be merged.