Implement unstable SLO resource #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
aschepis
force-pushed
the
aschepis/unstable-slo-resource-2
branch
from
b149cd7 to
500e3f5
Compare
marcushill
approved these changes
Dec 2, 2024
| @@ -1976,6 +1976,9 @@ | |||
| }, | |||
| "span_count": { | |||
| "$ref": "#/definitions/TraceSearchFilterCountFilter" | |||
| }, | |||
| "is_root_span": { | |||
| "$ref": "#/definitions/TraceSearchFilterBoolFilter" | |||
There was a problem hiding this comment.
Is it expected to see other things that aren't SLO related in this PR? I assume it means someone on another team just didn't run a gen command.
There was a problem hiding this comment.
it CAN happen if we haven't updated in a while. not a big deal
| // SwaggerParam is the name of the parameter to use in the swagger client request/response | ||
| // types. This will normally be the same as SwaggerType, but will be different for the | ||
| // SLO resource, where it is "Slo" instead of "SLO". | ||
| SwaggerParam string |
There was a problem hiding this comment.
This is just an override for SwaggerType, right? Something like SwaggerAPIType? "Param" confuses me here, but I don't have an explicit better name.
There was a problem hiding this comment.
because it is used the parameter name for the request/responses
bg451
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new unstable resource for SLOs