add examples and tests to verify that their schema loads and plans work #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
aschepis
force-pushed
the
aschepis/test-examples
branch
from
305abc2 to
abf8aef
Compare
prashantv
reviewed
Apr 25, 2024
aschepis
force-pushed
the
aschepis/test-examples
branch
from
abf8aef to
cd793fc
Compare
prashantv
changed the title
prashantv
approved these changes
Apr 29, 2024
| @@ -0,0 +1,4 @@ | |||
| resource "chronosphere_team" "t" { | |||
There was a problem hiding this comment.
optional: could this be a symlink to ../teams/main.tf
| @@ -0,0 +1,23 @@ | |||
| resource "chronosphere_drop_rule" "mah-drop-rule" { | |||
There was a problem hiding this comment.
nit: mind getting rid of "mah" and replacing it with something else? (purely cosmetic)
| @@ -0,0 +1,7 @@ | |||
| resource "chronosphere_gcp_metrics_integration" "customer" { | |||
| name = "GCP Metrics Integration" | |||
| slug = "test-gcp-metrics-integration" | |||
There was a problem hiding this comment.
for follow-up, this example is pretty light, doesn't have any metric_groups which seems to be the main entity body
cc @kirgirchrono
| @@ -0,0 +1,22 @@ | |||
| resource "chronosphere_grafana_dashboard" "my_dashboard" { | |||
There was a problem hiding this comment.
since we call them classic dashboards, should we drop the support for the old name here? cc @bg451
| @@ -0,0 +1,23 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
let's delete this file (creating a service isn't supported)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.