clarify ""Max-age > 10 years" warning #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nharper
reviewed
Nov 26, 2020
header.go
Outdated
| @@ -242,7 +242,7 @@ func preloadableHeaderMaxAge(hstsHeader HSTSHeader) Issues { | |||
| issues = issues.addWarningf( | |||
| "header.preloadable.max_age.over_10_years", | |||
| "Max-age > 10 years", | |||
| "FYI: The max-age (%d seconds) is longer than 10 years, which is an unusually long value.", | |||
| "FYI: The max-age (%d seconds) is longer than 10 years, which is an unusually long value, and may be disregarded by some browsers.", | |||
There was a problem hiding this comment.
The wording "may be disregarded" makes it sound like the browser will disregard the max-age value (and thus the HSTS header) altogether, which is not the case. How about "may be capped at a lower value" instead?
There was a problem hiding this comment.
That's a valid concern. Revising.
|
For what it's worth, I believe:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The warning for a max-age > 10 years does not currently explain why that may be an issue. Explanatory text added.