Don't attempt to save non-existent external script files (#634)

christophhart · Dec 8, 2024 · d890255 · d890255 · davidhealey · Dec 18, 2024
1 parent 50ed899
commit d890255
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/hi_core/hi_core/GlobalScriptCompileBroadcaster.cpp b/hi_core/hi_core/GlobalScriptCompileBroadcaster.cpp
@@ -92,6 +92,11 @@ void GlobalScriptCompileBroadcaster::clearIncludedFiles()
 	includedFiles.clear();
 }
 
+void GlobalScriptCompileBroadcaster::removeIncludedFile(int index)
+{
+	includedFiles.remove(index);
+}
+
 void GlobalScriptCompileBroadcaster::restoreIncludedScriptFilesFromSnippet(const ValueTree& snippetTree)
 {
 #if USE_BACKEND
@@ -217,9 +222,15 @@ void GlobalScriptCompileBroadcaster::setWebViewRoot(File newRoot)
 void GlobalScriptCompileBroadcaster::saveAllExternalFiles()
 {
 	for(int i = 0; i < getNumExternalScriptFiles(); i++)
-	{
+	{		
 		auto ef = getExternalScriptFile(i);
 
+		if (!ef->getFile().exists())
+		{
+				removeIncludedFile(i);
+				continue;
+		}
+
 		if(ef->getResourceType() == ExternalScriptFile::ResourceType::EmbeddedInSnippet)
 		{
 			debugToConsole(dynamic_cast<MainController*>(this)->getMainSynthChain(), "Skip writing embedded file " + ef->getFile().getFileName() + " to disk...");

diff --git a/hi_core/hi_core/GlobalScriptCompileBroadcaster.h b/hi_core/hi_core/GlobalScriptCompileBroadcaster.h
@@ -251,6 +251,7 @@ class GlobalScriptCompileBroadcaster
 	ExternalScriptFile::Ptr getExternalScriptFile(int index) const;
 
 	void clearIncludedFiles();
+	void removeIncludedFile(int index);
 
 	void restoreIncludedScriptFilesFromSnippet(const ValueTree& snippetTree);