- fixed compilation on macOS

- fixed crash when using new method with uninitialised routing manager
christophhart · Oct 5, 2024 · a7fa575 · a7fa575
1 parent 8a0d61f
commit a7fa575
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/hi_backend/backend/BackendApplicationCommands.cpp b/hi_backend/backend/BackendApplicationCommands.cpp
@@ -3292,11 +3292,17 @@ void BackendCommandTarget::Actions::createGlobalCableCppCode(BackendRootWindow*
 {
 	auto rm = dynamic_cast<scriptnode::routing::GlobalRoutingManager*>(bpe->getBackendProcessor()->getGlobalRoutingManager());
 
+	if(rm == nullptr)
+	{
+		PresetHandler::showMessageWindow("No global cables present", "You need to add global cables before using this method", PresetHandler::IconType::Error);
+		return;
+	}
+
 	auto cableList = rm->getIdList(scriptnode::routing::GlobalRoutingManager::SlotBase::SlotType::Cable);
 
 	if(cableList.isEmpty())
 	{
-		PresetHandler::showYesNoWindow("No global cables present", "You need to add global cables before using this method", PresetHandler::IconType::Error);
+		PresetHandler::showMessageWindow("No global cables present", "You need to add global cables before using this method", PresetHandler::IconType::Error);
 		return;
 	}
 

diff --git a/hi_dsp_library/dsp_nodes/RoutingNodes.h b/hi_dsp_library/dsp_nodes/RoutingNodes.h
@@ -1221,18 +1221,17 @@ template <typename... Ts> struct global_cable_cpp_manager: private advanced_tupl
 {
 	virtual ~global_cable_cpp_manager()
 	{
-		connectToRuntimeTarget(false, {});
+		this->connectToRuntimeTarget(false, {});
 	}
 
 	void connectToRuntimeTarget(bool addConnection, const runtime_target::connection& c)
 	{
-		static constexpr int size = sizeof...(Ts);
 		reset_each(addConnection, c, this->getIndexSequence());
 	}
 
 	template <auto CableIndex> void setGlobalCableValue(double value)
 	{
-		this->get<(int)CableIndex>().setValue(value);
+		this->get<(int)CableIndex>().template setValue(value);
 	}
 
 private: