- fix filter node enable parameter switching at 0.0 instead of 0.5

- fix harcoded FX corrupting XML when using Faust effects with invalid parameter IDs
christophhart · Nov 18, 2024 · 085d1a3 · 085d1a3
1 parent 558501f
commit 085d1a3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/hi_core/hi_modules/effects/fx/SlotFX.cpp b/hi_core/hi_modules/effects/fx/SlotFX.cpp
@@ -810,7 +810,8 @@ void HardcodedSwappableEffect::restoreHardcodedData(const ValueTree& v)
 
 		for (const auto& p : OpaqueNode::ParameterIterator(*opaqueNode))
 		{
-			auto value = v.getProperty(p.info.getId(), p.info.defaultValue);
+			auto id = getSanitizedParameterId(p.info.getId());
+			auto value = v.getProperty(id, p.info.defaultValue);
 			setHardcodedAttribute(p.info.index, value);
 		}
 	}
@@ -835,7 +836,7 @@ ValueTree HardcodedSwappableEffect::writeHardcodedData(ValueTree& v) const
 	{
 		for (const auto& p : OpaqueNode::ParameterIterator(*opaqueNode))
 		{
-			auto id = p.info.getId();
+			auto id = getSanitizedParameterId(p.info.getId());
 
 			if(auto ptr = getParameterPtr(p.info.index))
 				v.setProperty(id, *ptr, nullptr);

diff --git a/hi_core/hi_modules/effects/fx/SlotFX.h b/hi_core/hi_modules/effects/fx/SlotFX.h
@@ -43,6 +43,12 @@ class HardcodedSwappableEffect : public HotswappableProcessor,
 {
 public:
 
+	static Identifier getSanitizedParameterId(const String& id)
+	{
+		auto sanitized = id.removeCharacters(" \t\n/-+.,");
+		return Identifier(sanitized);
+	}
+
 	virtual ~HardcodedSwappableEffect();
 
 	// ===================================================================================== Complex Data API calls

diff --git a/hi_dsp_library/dsp_nodes/FilterNode.cpp b/hi_dsp_library/dsp_nodes/FilterNode.cpp
@@ -84,8 +84,7 @@ void FilterNodeBase<FilterType, NV>::setFrequency(double newFrequency)
 template <class FilterType, int NV>
 void FilterNodeBase<FilterType, NV>::setEnabled(double isEnabled)
 {
-	enabled = isEnabled;
-
+	enabled = isEnabled > 0.5;
 	this->sendCoefficientUpdateMessage();
 }