Update CI to use current Ruby #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These versions are non-functional with current versions of Ruby. Updating them allows us to start the test suite.
Both do similar monkey patching and when both are loaded, unexpected side effects happen.
The test suite use the RSpec 1 syntax with `should` that got deprecated. In order to ease up the transition, for now we want to stick with the `should` syntax, and *not* use `expect`. While here, also ensure exceptions are raised when deprecated features are used.
Running the test suite fail because some mocks created in other tests are leaked and used again in other tests. Reconfiguring logging help, so do this for now.
Expectation defined at [...] expected keyword arguments (...), but received positional hash ({...}). These will stop matching when strict keyword argument matching is enabled. See the documentation for Mocha::Configuration#strict_keyword_argument_matching=.
Older versions of Ruby where happy to deserialize aly kind of data, but nowadays you can't trust what people put on the internet.
Matching a non-string value against a regular expression does not make sense, and in the test suite we pass an integer. This used to work with older versions of Ruby but now raise an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependencies used by the project are not compatible with the current versions of Ruby.
This PR remove the constraints on the gems needed to run the test suite and adjust the code so that the test suite can run with modern Ruby.
This require a recent version ofmcollective-testnot yet released, so CI failures are expected at the moment.