Skip to content

Commit

Permalink
Added required --force-bls-withdrawal-credentials description to `-…
Browse files Browse the repository at this point in the history
…-disable-deposits` usage (sigp#6436)

* cli description

* complied docs changes

* reverted changes and script amended

* fix

* reverting unwanted changes

* making linter happy

* requested changes

* Merge branch 'unstable' into cli-fix

* Merge branch 'unstable' into cli-fix
  • Loading branch information
hopinheimer authored and chong-he committed Nov 26, 2024
1 parent 855e6b1 commit e39e696
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
4 changes: 3 additions & 1 deletion book/src/help_vm_create.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ Flags:
When provided don't generate the deposits JSON file that is commonly
used for submitting validator deposits via a web UI. Using this flag
will save several seconds per validator if the user has an alternate
strategy for submitting deposits.
strategy for submitting deposits. If used, the
--force-bls-withdrawal-credentials is also required to ensure users
are aware that an --eth1-withdrawal-address is not set.
--disable-log-timestamp
If present, do not include timestamps in logging output.
--disable-malloc-tuning
Expand Down
2 changes: 1 addition & 1 deletion scripts/cli.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ write_to_file() {
printf "# %s\n\n\`\`\`\n%s\n\`\`\`" "$program" "$cmd" > "$file"

# Adjust the width of the help text and append to the end of file
sed -i -e '$a\'$'\n''\n''<style> .content main {max-width:88%;} </style>' "$file"
printf "\n\n%s\n" "<style> .content main {max-width:88%;} </style>" >> "$file"
}

CMD=./target/release/lighthouse
Expand Down
4 changes: 3 additions & 1 deletion validator_manager/src/create_validators.rs
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ pub fn cli_app() -> Command {
"When provided don't generate the deposits JSON file that is \
commonly used for submitting validator deposits via a web UI. \
Using this flag will save several seconds per validator if the \
user has an alternate strategy for submitting deposits.",
user has an alternate strategy for submitting deposits. \
If used, the --force-bls-withdrawal-credentials is also required \
to ensure users are aware that an --eth1-withdrawal-address is not set.",
)
.action(ArgAction::SetTrue)
.help_heading(FLAG_HEADER)
Expand Down

0 comments on commit e39e696

Please sign in to comment.