[WIP] Quick band-aid fix for MPI termination #374
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick band-aid fix to ensure we don't leave straggler processes around after MPI processes receive a
SIGABRT
,SIGINT
, orSIGTERM
from Torque.A much better approach would be to use context managers to ensure that all files are gracefully synced and closed and MPI is aborted as the program terminates, but this will require some refactoring/redesign. As a result, the current solution may result in some additional data corruption that is hopefully minimized by the fact that NetCDF syncs the files each iteration.