Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non fp v #58

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Fix non fp v #58

merged 3 commits into from
Dec 25, 2024

Conversation

Avimitin
Copy link
Contributor

@Avimitin Avimitin commented Dec 19, 2024

Continue works on #53. Waiting for review on macro modification riscv/riscv-test-env#45.

@Avimitin Avimitin force-pushed the fix-non-fp-v branch 2 times, most recently from 766ade2 to 68c61d1 Compare December 21, 2024 08:40
- add RVTEST_RV{32,64}UVX
- add RVTEST_ZVE32X_ENABLE

Signed-off-by: Avimitin <[email protected]>
@Avimitin Avimitin force-pushed the fix-non-fp-v branch 5 times, most recently from 2d0528b to 07b0d87 Compare December 25, 2024 05:49
@Avimitin
Copy link
Contributor Author

PR done, waiting for review.

Copy link
Member

@ksco ksco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall looks good, a minor change is proposed.

generator/insn.go Outdated Show resolved Hide resolved
@Avimitin
Copy link
Contributor Author

Fixed. Waiting for CI pass.

@ksco
Copy link
Member

ksco commented Dec 25, 2024

Fixed. Waiting for CI pass.

It's a capital X.

sequencer and others added 2 commits December 25, 2024 15:47
The latest commit contains macro specialized for RVV without FP support.
@Avimitin
Copy link
Contributor Author

Oops...It should be correct now.

@ksco ksco merged commit 52ccb79 into chipsalliance:main Dec 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants