-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non fp v #58
Merged
Merged
Fix non fp v #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avimitin
force-pushed
the
fix-non-fp-v
branch
2 times, most recently
from
December 21, 2024 08:40
766ade2
to
68c61d1
Compare
- add RVTEST_RV{32,64}UVX - add RVTEST_ZVE32X_ENABLE Signed-off-by: Avimitin <[email protected]>
Avimitin
force-pushed
the
fix-non-fp-v
branch
5 times, most recently
from
December 25, 2024 05:49
2d0528b
to
07b0d87
Compare
PR done, waiting for review. |
ksco
reviewed
Dec 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Overall looks good, a minor change is proposed.
Avimitin
force-pushed
the
fix-non-fp-v
branch
from
December 25, 2024 07:43
07b0d87
to
afd459f
Compare
Fixed. Waiting for CI pass. |
It's a capital X. |
Signed-off-by: Avimitin <[email protected]>
The latest commit contains macro specialized for RVV without FP support.
Avimitin
force-pushed
the
fix-non-fp-v
branch
from
December 25, 2024 07:47
afd459f
to
4174b75
Compare
Oops...It should be correct now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue works on #53. Waiting for review on macro modification riscv/riscv-test-env#45.