Allow unknown keys when parsing csig files and update JSON files #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The versioning of the two file formats unfortunately didn't work out as well as I hoped. To support older versions of Custota, the server would need to keep serving the old file formats without any good upgrade path besides doing a hard cutover at some point. Instead, let's try taking a page from the protobuf book and just make version 2 extensible by adding new fields. Custota from now on will just ignore fields it does not understand. I'll plan on having custota-tool output all fields forever for future backwards compatibility. Issue: #94 Signed-off-by: Andrew Gunnerson <[email protected]>
chenxiaolong
force-pushed
the
lenient-parsing
branch
from
4610ea0 to
54a776a
Compare
chenxiaolong
added a commit
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Andrew Gunnerson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versioning of the two file formats unfortunately didn't work out as well as I hoped. To support older versions of Custota, the server would need to keep serving the old file formats without any good upgrade path besides doing a hard cutover at some point.
Instead, let's try taking a page from the protobuf book and just make version 2 extensible by adding new fields. Custota from now on will just ignore fields it does not understand. I'll plan on having custota-tool output all fields forever for future backwards compatibility.
Issue: #94