Update toml-rb requirement from ~> 1.0 to >= 1, < 3 #283

balasankarc · 2022-07-22T06:22:04Z

Adapted from #219. For some reason, changes from that PR didn't reach main branch.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

I have read the CONTRIBUTING document.
I have run the pre-merge tests locally and they pass.
I have updated the documentation accordingly.
I have added tests to cover my changes.
All new and existing tests passed.
All commits have been signed-off for the Developer Certificate of Origin.

Adapted from chef#219 Signed-off-by: Balasankar 'Balu' C <[email protected]>

balasankarc · 2022-07-22T06:30:16Z

@mimaslanka Could you please take a look? Thanks.

The buildkite failure exists in main branch also and is not introduced by this PR - https://buildkite.com/chef-oss/chef-license-scout-main-verify/builds/173#01817148-c081-4015-b730-86468cc6bd49

mimaslanka · 2022-07-22T15:24:22Z

@balasankarc it tells you what is wrong:

lib/license_scout/config.rb:18:1: R: [Correctable] Chef/Ruby/UnlessDefinedRequire: Workaround rubygems slow requires by only running require if the class isn't already defined

You just have to fix that to get it to pass. Basically add something like:

require "json" unless defined?(JSON)

balasankarc · 2022-08-03T06:43:33Z

@balasankarc it tells you what is wrong:

lib/license_scout/config.rb:18:1: R: [Correctable] Chef/Ruby/UnlessDefinedRequire: Workaround rubygems slow requires by only running require if the class isn't already defined

You just have to fix that to get it to pass. Basically add something like:

require "json" unless defined?(JSON)

@mimaslanka I knew what is wrong and how to fix. But I wasn't sure if including that in this PR, where it is totally unrelated made sense. If you are ok with it, I am glad to do it.