A set of assorted fixes in logging and error propagation.

[osctobe]

The changes in this series are mostly independent and could be applied individually. If there are change requests I'll shuffle relevant commits to the back when addressing them.

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (53dd6ba) 70.33% compared to head (02f188b) 70.31%.

❗ Current head 02f188b differs from pull request most recent head ad9c583. Consider uploading reports for the commit ad9c583 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           criu-dev    #2194      +/-   ##
============================================
- Coverage     70.33%   70.31%   -0.02%     
============================================
  Files           134      134              
  Lines         34026    34025       -1     
============================================
- Hits          23932    23925       -7     
- Misses        10094    10100       +6     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Snorch]

One general note here, in criu there is a requirement to prefix subjects with component name. See https://github.com/checkpoint-restore/criu/blob/criu-dev/CONTRIBUTING.md#describe-your-changes

[Snorch]

Subject: [PATCH] util: Remove error logs for ignored or otherwise logged
diff --git a/criu/netfilter.c b/criu/netfilter.c
index <some index>
--- a/criu/netfilter.c
+++ b/criu/netfilter.c
diff --git a/criu/util.c b/criu/util.c
index <some index>
--- a/criu/util.c
+++ b/criu/util.c

In this case right prefix would be util/netfilter: or just log:

ps: don't forget to fix CI =)

[osctobe]

I've split the build parts into a separate PR.

[0x7f454c46]

Change-Id: I8e5e4953f0231ed935ef3dbbab800080e4ee549f clean this from the commit.

You don't submit those to linux/kernel, neither you do to criu. We hold the same rule, see:
https://elixir.bootlin.com/linux/latest/source/Documentation/dev-tools/checkpatch.rst#L593
The Change-Id line must be removed before submitting.