Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sudo rather than sg on ubuntu-24.04 runners #140

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Use sudo rather than sg on ubuntu-24.04 runners #140

merged 3 commits into from
Sep 24, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Sep 24, 2024 •
edited
Loading

Overview

Addresses issue #139 on ubuntu-24.04 workers

Details

  • tests on broader versions of ubuntu runners
  • fixes unit test issue created by newer websockets library

Failing tests:

mateoflorido
mateoflorido approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@addyess addyess merged commit 2ea3e38 into main Sep 24, 2024
12 of 14 checks passed
@addyess addyess deleted the bug/139/dont-build-with-sg branch September 24, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateoflorido mateoflorido mateoflorido approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @mateoflorido