Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add clearer warning and recommendation for useId #1725

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

booc0mtaco
Copy link
Contributor

Summary:

This updates the emitted warning message when using the built-in fallback for useId in react < 18 projects. Includes a recommendation as well.

Test Plan:

  • n/a (documentation only change)

@github-actions
Copy link

github-actions bot commented Aug 15, 2023

size-limit report 📦

Path Size
components 95.55 KB (+0.06% 🔺)
styles 32.68 KB (0%)

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1725 (a23e8fd) into main (c935b4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1725   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files         146      146           
  Lines        2575     2575           
  Branches      664      664           
=======================================
  Hits         2376     2376           
  Misses        198      198           
  Partials        1        1           
Files Changed Coverage Δ
src/util/useId.ts 38.46% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@booc0mtaco booc0mtaco requested a review from a team August 15, 2023 23:49
@booc0mtaco booc0mtaco changed the base branch from main to next August 16, 2023 17:27
@booc0mtaco booc0mtaco merged commit 6904e29 into next Aug 16, 2023
6 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/x-update-useid-warning-msg branch August 16, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants