Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: split t2 colors stories and remove t2 stories aggregator #1719

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented Aug 7, 2023

Summary:

  • removes aggregating story file Tier2Tokens.stories.jsx and jsut converts the individual componets to story files
    • similar work will be done for T1 and T3 tokens
  • splits T2 colors as requested by design and I also agree as part of survey feedback to not have to scroll that much on ZH
  • adds suggested TW class and design token string to the relevant color
    • follow up pr will attempt to differentiate these (is follow up since it'll also affect the other tokens pages)
  • converts some jsx to tsx

Test Plan:

  • Manually tested my changes, and here are the details:
    • no stories changes except for t2 colors
    • adds the tw class and figma design token next to the colors
      Screenshot 2023-08-07 at 11 49 03 AM

@jinlee93 jinlee93 requested a review from a team August 7, 2023 18:50
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

size-limit report 📦

Path Size
components 95.49 KB (0%)
styles 32.76 KB (0%)

@jinlee93
Copy link
Contributor Author

jinlee93 commented Aug 7, 2023

Interesting that chromatic flags these as new stories even tho they're structured and look exactly the same
image

@booc0mtaco
Copy link
Contributor

@jinlee93 looks good. where do the token names in figma come from?

@jinlee93
Copy link
Contributor Author

jinlee93 commented Aug 7, 2023

@jinlee93 looks good. where do the token names in figma come from?

It comes from the UI foundations Figma file
image

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #1719 (2f60a40) into next (41cf335) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1719   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         146      146           
  Lines        2579     2579           
  Branches      664      664           
=======================================
  Hits         2380     2380           
  Misses        198      198           
  Partials        1        1           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@booc0mtaco booc0mtaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names differ slightly in format from figma to code, so we transform the code token names into the figma equivalents for reference. LGTM

@jinlee93 jinlee93 merged commit d200312 into next Aug 7, 2023
6 checks passed
@jinlee93 jinlee93 deleted the jlee/cleanT2docs branch August 7, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants