-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: lambda vpc_config and memory_size #301
Conversation
aws-lambda-function/outputs.tf
Outdated
value = aws_iam_role.role.name | ||
} | ||
|
||
output role_id { | ||
output "role_id" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [tflint] reported by reviewdog 🐶role_id
output has no description
aws-lambda-function/outputs.tf
Outdated
@@ -1,28 +1,28 @@ | |||
output arn { | |||
output "arn" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [tflint] reported by reviewdog 🐶arn
output has no description
aws-lambda-function/outputs.tf
Outdated
description = "If the lambda function is published, the qualified_arn points at the latest version number." | ||
value = aws_lambda_function.lambda.qualified_arn | ||
} | ||
|
||
output invoke_arn { | ||
output "invoke_arn" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [tflint] reported by reviewdog 🐶invoke_arn
output has no description
aws-lambda-function/outputs.tf
Outdated
value = aws_lambda_function.lambda.invoke_arn | ||
} | ||
|
||
output function_name { | ||
output "function_name" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [tflint] reported by reviewdog 🐶function_name
output has no description
aws-lambda-function/outputs.tf
Outdated
value = aws_lambda_function.lambda.function_name | ||
} | ||
|
||
output log_group_name { | ||
output "log_group_name" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [tflint] reported by reviewdog 🐶log_group_name
output has no description
aws-lambda-function/outputs.tf
Outdated
value = aws_cloudwatch_log_group.log.name | ||
} | ||
|
||
output role_name { | ||
output "role_name" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [tflint] reported by reviewdog 🐶role_name
output has no description
aws-lambda-function/variables.tf
Outdated
type = string | ||
default = null | ||
} | ||
|
||
variable log_retention_in_days { | ||
variable "log_retention_in_days" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [tflint] reported by reviewdog 🐶log_retention_in_days
variable has no description
aws-lambda-function/variables.tf
Outdated
type = string | ||
default = null | ||
} | ||
|
||
variable filename { | ||
variable "filename" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [tflint] reported by reviewdog 🐶filename
variable has no description
aws-lambda-function/variables.tf
Outdated
type = string | ||
description = "KMS key used to encrypt environment variables." | ||
default = null | ||
} | ||
|
||
variable source_code_hash { | ||
variable "source_code_hash" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [tflint] reported by reviewdog 🐶source_code_hash
variable has no description
type = bool | ||
description = "Is this lambda going to be used with a Cloufront distribution? If you set this, you will not have control over log retention, and you cannot include environment variables." | ||
default = false | ||
} | ||
|
||
variable reserved_concurrent_executions { | ||
variable "reserved_concurrent_executions" { | ||
type = number | ||
description = "Set reserved_concurrent_executions for this function. See [docs](https://docs.aws.amazon.com/lambda/latest/dg/configuration-concurrency.html)." | ||
default = -1 // aws default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single line comments should begin with #
role = aws_iam_role.role.name | ||
policy_arn = aws_iam_policy.lambda_logging.arn | ||
} | ||
|
||
// Execution role basic permissions | ||
data "aws_iam_policy_document" "role" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data "aws_iam_policy_document" "role" is declared but not used
role = aws_iam_role.role.name | ||
policy_arn = aws_iam_policy.lambda_logging.arn | ||
} | ||
|
||
// Execution role basic permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single line comments should begin with #
…da-subnets-memory
Summary
Allow lambdas to configure vpc_config and memory_size
Test Plan
References