Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: lambda vpc_config and memory_size #301

Merged
merged 10 commits into from
Apr 14, 2021
Merged

Conversation

edulop91
Copy link
Contributor

Summary

Allow lambdas to configure vpc_config and memory_size

Test Plan

References

@edulop91 edulop91 requested a review from jgadling April 12, 2021 20:34
value = aws_iam_role.role.name
}

output role_id {
output "role_id" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [tflint] reported by reviewdog 🐶
role_id output has no description

@@ -1,28 +1,28 @@
output arn {
output "arn" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [tflint] reported by reviewdog 🐶
arn output has no description

description = "If the lambda function is published, the qualified_arn points at the latest version number."
value = aws_lambda_function.lambda.qualified_arn
}

output invoke_arn {
output "invoke_arn" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [tflint] reported by reviewdog 🐶
invoke_arn output has no description

value = aws_lambda_function.lambda.invoke_arn
}

output function_name {
output "function_name" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [tflint] reported by reviewdog 🐶
function_name output has no description

value = aws_lambda_function.lambda.function_name
}

output log_group_name {
output "log_group_name" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [tflint] reported by reviewdog 🐶
log_group_name output has no description

value = aws_cloudwatch_log_group.log.name
}

output role_name {
output "role_name" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [tflint] reported by reviewdog 🐶
role_name output has no description

type = string
default = null
}

variable log_retention_in_days {
variable "log_retention_in_days" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [tflint] reported by reviewdog 🐶
log_retention_in_days variable has no description

type = string
default = null
}

variable filename {
variable "filename" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [tflint] reported by reviewdog 🐶
filename variable has no description

type = string
description = "KMS key used to encrypt environment variables."
default = null
}

variable source_code_hash {
variable "source_code_hash" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [tflint] reported by reviewdog 🐶
source_code_hash variable has no description

type = bool
description = "Is this lambda going to be used with a Cloufront distribution? If you set this, you will not have control over log retention, and you cannot include environment variables."
default = false
}

variable reserved_concurrent_executions {
variable "reserved_concurrent_executions" {
type = number
description = "Set reserved_concurrent_executions for this function. See [docs](https://docs.aws.amazon.com/lambda/latest/dg/configuration-concurrency.html)."
default = -1 // aws default
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [tflint] reported by reviewdog 🐶
Single line comments should begin with #

role = aws_iam_role.role.name
policy_arn = aws_iam_policy.lambda_logging.arn
}

// Execution role basic permissions
data "aws_iam_policy_document" "role" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [tflint] reported by reviewdog 🐶
data "aws_iam_policy_document" "role" is declared but not used

role = aws_iam_role.role.name
policy_arn = aws_iam_policy.lambda_logging.arn
}

// Execution role basic permissions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [tflint] reported by reviewdog 🐶
Single line comments should begin with #

@edulop91 edulop91 merged commit 83e12bc into main Apr 14, 2021
@edulop91 edulop91 deleted the edu/lambda-subnets-memory branch April 14, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants