Output ALB listener ARNs from aws-ecs-service #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide the ability to customize the ALB's rules for an ECS service, we need to provide the ARN of the listener so that they can attach aws_lb_listener_rule instances with references to it. This PR outputs the ARN of the HTTPS listener (usually the one you want), and in cases where we do not auto-redirect the HTTP requests to HTTPS, the HTTP listener. (We intentionally do not output the HTTP listener when redirecting to HTTPS, since we'd prefer users not do any custom rules on the HTTP side.)