Support disabling versioning in private buckets (#122)

chanzuckerberg · Sep 16, 2019 · 6923e1b · 6923e1b
1 parent 96ea06d
commit 6923e1b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-0.18.2
+0.19.1
diff --git a/aws-s3-private-bucket/README.md b/aws-s3-private-bucket/README.md
@@ -5,6 +5,7 @@
 |------|-------------|:----:|:-----:|:-----:|
 | bucket\_name |  | string | n/a | yes |
 | bucket\_policy |  | string | `""` | no |
+| enable\_versioning | Keep old versions of overwritten S3 objects. | bool | `true` | no |
 | env |  | string | n/a | yes |
 | owner |  | string | n/a | yes |
 | project |  | string | n/a | yes |

diff --git a/aws-s3-private-bucket/main.tf b/aws-s3-private-bucket/main.tf
@@ -15,7 +15,7 @@ resource "aws_s3_bucket" "bucket" {
   policy = "${data.aws_iam_policy_document.bucket_policy.json}"
 
   versioning {
-    enabled = true
+    enabled = var.enable_versioning
   }
 
   # TODO

diff --git a/aws-s3-private-bucket/variables.tf b/aws-s3-private-bucket/variables.tf
@@ -22,3 +22,9 @@ variable "service" {
 variable "owner" {
   type = "string"
 }
+
+variable "enable_versioning" {
+  type        = bool
+  description = "Keep old versions of overwritten S3 objects."
+  default     = true
+}