chore: Build an x86 version of the apiv2 image to execute in aws batch. #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manasaV3
reviewed
Nov 7, 2024
Comment on lines
64
to
65
| context: ./apiv2 | ||
| file: ./apiv2/Dockerfile |
There was a problem hiding this comment.
Not a blocker: It looks like, the only difference between the ingestion job and this one are these two values. What are your thoughts on having a composite action that can be used by both these jobs?
There was a problem hiding this comment.
I updated it to use a matrix build. check again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our
push-local-ingestor-buildmake target to build both an apiv2 image (for db ingestion) and an ingestion_tools image (for s3 ingestion and apiv1 db ingestion) and also updates the GitHub action that pushes our ingestion_tools docker image to build an apiv2 image as well.It's important to note that we've taken on this extra step because we run db ingestion in an x86-only environment in AWS batch, while our apiv2 service runs on ARM. We're using python and libraries that generally aren't tied to CPU architecture, so I don't expect any major differences in behavior between the different images