-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: s3 data validation: cross checking tiltseries & frames files #229
feat: s3 data validation: cross checking tiltseries & frames files #229
Conversation
…i/s3-data-validation-dataset-deposition-photos
…i/s3-data-validation-dataset-deposition-photos
… into daniel-ji/s3-data-validation-frames-gains
…ji/s3-data-validation-tiltseries
…ji/s3-data-validation-tiltseries
9ad946a
to
1deb4ab
Compare
17f776d
to
ca40efe
Compare
@pytest.fixture(autouse=True) | ||
def max_frames_count(self, tiltseries_metadata: Dict): | ||
# TODO FIXME how to check if -0.0 should exist | ||
return ( | ||
tiltseries_metadata["tilt_range"]["max"] - tiltseries_metadata["tilt_range"]["min"] | ||
) / tiltseries_metadata["tilt_step"] + 1 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might not always hold true, as there is a possibility of frames that were generated not being used for the tiltseries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'll remove all the max_frames_count checks in this PR and the future ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments documenting the tests are really helpful. 🔥
Merge after #223.
See the Tilts & RawTilts & Angles Cross Checks section of https://docs.google.com/document/d/1yMKM0DW9KRhlcYiBGPcR7oW0liGtUew6NAmBhMg5U3w/edit.
Documentation from the code: