Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avatar): check removed avatar node type #1822

Merged

Conversation

healtheloper
Copy link
Contributor

📝 Description

Checking the NodeType for errors caused by having a TextNode instead of an HTMLElement in removedNodes.

⛳️ Current behavior (updates)

If the name of the Avatar is an empty string, this type error occurs.

스크린샷 2024-09-06 오전 2 34 36

🚀 New behavior

No error

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Copy link

changeset-bot bot commented Sep 5, 2024

🦋 Changeset detected

Latest commit: 0d8efc7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 74 packages
Name Type
@zag-js/avatar Patch
@zag-js/anatomy-icons Patch
@zag-js/anatomy Patch
@zag-js/core Patch
@zag-js/docs Patch
@zag-js/preact Patch
@zag-js/react Patch
@zag-js/solid Patch
@zag-js/svelte Patch
@zag-js/vue Patch
@zag-js/accordion Patch
@zag-js/carousel Patch
@zag-js/checkbox Patch
@zag-js/clipboard Patch
@zag-js/collapsible Patch
@zag-js/color-picker Patch
@zag-js/combobox Patch
@zag-js/date-picker Patch
@zag-js/dialog Patch
@zag-js/editable Patch
@zag-js/file-upload Patch
@zag-js/floating-panel Patch
@zag-js/hover-card Patch
@zag-js/menu Patch
@zag-js/number-input Patch
@zag-js/pagination Patch
@zag-js/pin-input Patch
@zag-js/popover Patch
@zag-js/presence Patch
@zag-js/progress Patch
@zag-js/qr-code Patch
@zag-js/radio-group Patch
@zag-js/rating-group Patch
@zag-js/select Patch
@zag-js/signature-pad Patch
@zag-js/slider Patch
@zag-js/splitter Patch
@zag-js/steps Patch
@zag-js/switch Patch
@zag-js/tabs Patch
@zag-js/tags-input Patch
@zag-js/time-picker Patch
@zag-js/timer Patch
@zag-js/toast Patch
@zag-js/toggle-group Patch
@zag-js/tooltip Patch
@zag-js/tour Patch
@zag-js/tree-view Patch
@zag-js/store Patch
@zag-js/types Patch
@zag-js/aria-hidden Patch
@zag-js/auto-resize Patch
@zag-js/collection Patch
@zag-js/color-utils Patch
@zag-js/utils Patch
@zag-js/date-utils Patch
@zag-js/dismissable Patch
@zag-js/dom-event Patch
@zag-js/dom-query Patch
@zag-js/element-rect Patch
@zag-js/element-size Patch
@zag-js/file-utils Patch
@zag-js/focus-visible Patch
@zag-js/form-utils Patch
@zag-js/i18n-utils Patch
@zag-js/interact-outside Patch
@zag-js/live-region Patch
@zag-js/number-utils Patch
@zag-js/numeric-range Patch
@zag-js/popper Patch
@zag-js/rect-utils Patch
@zag-js/remove-scroll Patch
@zag-js/stringify-state Patch
@zag-js/text-selection Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-solid ✅ Ready (Inspect) Visit Preview Sep 5, 2024 8:17pm
zag-svelte ✅ Ready (Inspect) Visit Preview Sep 5, 2024 8:17pm
zag-vue ✅ Ready (Inspect) Visit Preview Sep 5, 2024 8:17pm
zag-website ✅ Ready (Inspect) Visit Preview Sep 5, 2024 8:17pm

Copy link

vercel bot commented Sep 5, 2024

@healtheloper is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

@zag-js/anatomy-icons

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/anatomy-icons@1822

@zag-js/anatomy

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/anatomy@1822

@zag-js/core

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/core@1822

@zag-js/docs

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/docs@1822

@zag-js/store

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/store@1822

@zag-js/types

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/types@1822

commit: 0d8efc7

@segunadebayo segunadebayo merged commit 6d958b3 into chakra-ui:main Sep 5, 2024
20 of 22 checks passed
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
@healtheloper healtheloper deleted the fix/avatar-removed-node-type branch September 6, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants