-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for react-icons #53
base: master
Are you sure you want to change the base?
Conversation
It seems listing "react-icons" as an "optionalDependency" in package.json results in an attempt to install it by default. I guess the alternative would be to simply leave it out of package.json entirely. |
This is building locally for me without issue. It seems the TeamCity build failure is unrelated to the code and something to do with the build environment:
|
Thanks for this! I'm wondering if it makes sense to just do a major version bump and include react-icons as a normal dependency. |
The popular react-icons module provides FontAwesome icons (among others) in best practice SVG format. I have put together a pull request that provides optional support for this library, which at the time of writing has almost 350k weekly downloads.