[sync] 2019/8/21 #433
Merged
[sync] 2019/8/21 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change suggests package authors to include better documentation for their packages, based on the Q2 2019 survey results, as described in the Medium article: https://medium.com/flutter/what-do-flutter-package-users-need-6ecba57ed1d6
* Add /go/ links section * Update firebase.json * Update firebase.json
* Fixes two iOS setup bugs. * Further tweaks * Incorporating feedback.
missing countryCode target for CN, TW and HK in describing how to express every variant of Chinese.
"App State" in this case is a thing, so without the word "an" the sentence is a bit rough. I had to read it 3x before it clicked" Current: "This works okay, but for app state that you need to modify from many different places..." Proposed: "This works okay, but for an app state that you need to modify from many different places..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #374