[sync] 2024/08/03 #1471
Merged
[sync] 2024/08/03 #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current example does not work, as the `registrar` variable is
confused with the `registrar` method causing a
`'NSInternalInconsistencyException', reason:
'Duplicate plugin key: <...>'` exception.
The `register(
_ factory: any FlutterPlatformViewFactory,
withId factoryId: String)` method needs to be called with the created
`weak var registrar`, not with a new `registrar` method.
I also propose a change to the variable name, not to be confused with
the `registrar` method.
- Remove the specially added `pagecontent` fields, which also wasn't working on the Material 2 page, and inline similar content directly into the relevant Markdown pages. - Use shorter description for Material 3 on the index page, as it was causing other cards to be too large, and the transition info isn't super relevant to those navigating the index. - Update "Text Input" subcategory of Material 3 to "Text input" for consistency with other headers on the site Contributes to flutter/website#1897
We no longer use the bootstrap features that require it. Contributes to flutter/website#8030
- Removes usage of bootstrap breadcrumb styles - Contributes to flutter/website#8030 - Moves the 'View source' and 'Report an issue' buttons to text at the end of the page - Add "Unless stated otherwise, the documentation on this site reflects the latest stable version of Flutter" text to the bottom of each page - Include Git last modified date alongside new source and report issue location - Fixes flutter/website#1174
_Description of what this PR is changing or adding, and why:_ This updates the deprecation policy. We are pausing our cadence of removing deprecated API from the framework until we can create a new policy. The last couple of cycles we noticed customers having more difficult migrations, and it being harder to remove the APIs in the scheduled time period. So we need to reevaluate the policy and update it. This is the policy working as intended. Signals like flutter/tests provide feedback on how we are affecting users - so that for folks that contributed! Related to flutter/flutter#151257 ## Presubmit checklist - [ ] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Anthony Sansone <[email protected]>
- Switches the files from JSON to YAML for an easier editing and reviewing experience - Uses consistence capitalization across category and subcategory titles - Don't include raw HTML in the file for images - Don't require an image source to be specified if using the placeholder image - Add some alt text, with opportunity for more specific text in the future Fixes flutter/website#1897
This results in an easier contribution experience, increased consistency, as well as slightly improved access as now each video has a corresponding link text.
This adds documentation on authoring and using platform views for Flutter apps targeting macOS. The initial version of this documentation is Swift-only, but a follow-up will add Objective-C example code. Fixes: #9424 ## Presubmit checklist - [X] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [X] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [X] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [X] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Fixes flutter/website#8889, leaving the remaining usages to be tackled as part of flutter/website#8030
I removed the last pages that used these custom styles a while ago (flutter/website#10176).
This codelab manually handled play and pause of its one inline video, perhaps for a less intrusive UI, but it's less accessible and increases site maintenance costs for only one usage.
- Stop requiring tables be manually wrapped by `<div class="table-wrapper">[...]</div>`. - Do so by implementing custom wrapping in the `markdown.js` file - Drop `markdown-it-table` dependency
- Use a responsive grid system, so card decks don't need to manually specify row breaks, margins, etc - Prevent cards being too narrow/squished when browser is narrow but side menu is still present - Stops relying on some bootstrap styles for cards Contributes to flutter/website#8030
Also updates other npm dependencies :)
Cloud Build seems to only do a shallow clone, so "unshallowing" the checkout is required to get last modified information.
Fixes flutter/website#10854 A missing "/" at the beginning of the image URL broke the demo. This fixes that. --------- Co-authored-by: Parker Lougheed <[email protected]>
_Description of what this PR is changing or adding, and why:_ The test drive page is instructing to install the dart extension which was by default installed previously by the VsCode Flutter extension. _Issues fixed by this PR (if any):_ flutter/website#10856 _PRs or commits this PR depends on (if any):_ ## Presubmit checklist - [ ] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Bumps [examples/codelabs](https://github.com/flutter/codelabs) from `ec712d2` to `321cece`. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/flutter/codelabs/commit/321cece6564814f65ceb643baede2f02274437a1"><code>321cece</code></a> Bump actions/upload-artifact from 4.3.3 to 4.3.4 (<a href="https://redirect.github.com/flutter/codelabs/issues/2214">#2214</a>)</li> <li>See full diff in <a href="https://github.com/flutter/codelabs/compare/ec712d28ada90507f0eba8c53554d210b08162cb...321cece6564814f65ceb643baede2f02274437a1">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.3 to 4.3.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p> <blockquote> <h2>v4.3.4</h2> <h2>What's Changed</h2> <ul> <li>Update <code>@actions/artifact</code> version, bump dependencies by <a href="https://github.com/robherley"><code>@robherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/584">actions/upload-artifact#584</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.3...v4.3.4">https://github.com/actions/upload-artifact/compare/v4.3.3...v4.3.4</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/upload-artifact/commit/0b2256b8c012f0828dc542b3febcab082c67f72b"><code>0b2256b</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/584">#584</a> from actions/robherley/bump-pkgs</li> <li><a href="https://github.com/actions/upload-artifact/commit/488dcefb9bf01619ac19bad29c5c5409a1e4dd4c"><code>488dcef</code></a> licensed cache</li> <li><a href="https://github.com/actions/upload-artifact/commit/04c51f57662651dd3333286989e2db1111c0fd07"><code>04c51f5</code></a> ncc</li> <li><a href="https://github.com/actions/upload-artifact/commit/32a9e276a8f8ac18b4b2dce8213ed340ed4e5ed8"><code>32a9e27</code></a> bump <code>@actions/artifact</code> and npm audit</li> <li><a href="https://github.com/actions/upload-artifact/commit/552bf3722c16e81001aea7db72d8cedf64eb5f68"><code>552bf37</code></a> new version</li> <li><a href="https://github.com/actions/upload-artifact/commit/79616d2ded92999fceefea2ca2e4bdf6101fa919"><code>79616d2</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/565">#565</a> from actions/eggyhead/use-artifact-v2.1.6</li> <li>See full diff in <a href="https://github.com/actions/upload-artifact/compare/65462800fd760344b1a7b4382951275a0abb4808...0b2256b8c012f0828dc542b3febcab082c67f72b">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Related to flutter/flutter#151166 Summary of changes made: - if possible, adapt Groovy syntax to be valid Kotlin DSL syntax - if above is not possible, add a new tab showing valid Kotlin DSL syntax ([example](https://flutter-docs-prod--pr10846-chore-adapt-for-gradle-kts-cl6muvw5.web.app/add-to-app/android/project-setup)) - also adjusted indentation to be consistently 4 spaces (right now, it's a mix of 2 and 4 in our docs) I did not go over all Gradle-related content. This is _a start_ to this effort :) ## Presubmit checklist - [x] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
Fixes flutter/website#10866 Please look at the generated page, @zoeyfan **Staged:** https://flutter-docs-prod--pr10868-job-a47rpdoa.web.app/jobs/dre-china --------- Co-authored-by: Parker Lougheed <[email protected]>
Fixes broken table on platform adaptations page. https://flutter-docs-prod--pr10872-table-fix-aze89l98.web.app/platform-integration/platform-adaptations#widgets-with-adaptive-constructors
Fixes flutter/website#10821 cc @justinmc --------- Co-authored-by: Parker Lougheed <[email protected]>
Adds the `AlertDialog.adaptive` constructor (with images to the `.adaptive` table. Removed the section on how to manually convert an AlertDialog from m3 to Cupertino. Fixes flutter/website#9113
Fixes flutter/website#10862 --------- Co-authored-by: Parker Lougheed <[email protected]>
Update section about iOS apps _Description of what this PR is changing or adding, and why:_ The section about iOS apps was wrong or outdated. When following the current instructions, the app store entry would only show the english locale. Also, the official apple documentation does not mention changes to the Info.plist file: https://developer.apple.com/documentation/xcode/adding-support-for-languages-and-regions _Issues fixed by this PR (if any):_ flutter/website#10221 _PRs or commits this PR depends on (if any):_ ## Presubmit checklist - [x] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
This updates the SwiftPM docs to use non-increasing values for numbered
lists. This will make it easier to review future changes.
Previously if you inserted new list items, you would need to re-format
the content. For example:
```diff
+ 9. New content
- 9. Old content
- That takes two lines.
+ 10. Old content
+ That takes new lines.
```
Notice how list item 10 now has 1 more digit so all of its content had
to be shifted over by one space.
By using non-increasing values, you don't need to reformat the content.
For example:
```diff
+ 1. New content
1. Old content
That takes two lines.
```
Prepares for: flutter/flutter#152276
## Presubmit checklist
- [x] This PR is marked as draft with an explanation if not meant to
land until a future stable release.
- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.
…link (#10964) I added some notes when setting up Deeplink to help people know more about implementing this feature in case the application has many flavors. When I implemented this feature myself, I had difficulty knowing how to meet it for all 3 environments of development, staging, and production in my project. I searched and it was quite time-consuming. So I want to help people just read here to get enough necessary information ## Presubmit checklist - [x] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
Page URL: https://docs.flutter.dev/platform-integration/platform-channels?tab=type-mappings-kotlin-tab#step-3-add-an-android-platform-specific-implementation I fixed java sample code in how to use platform-channels. ## Presubmit checklist - [x] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
Begin addressing the feedback from the walkthrough meeting: flutter/flutter#152276 1. Updated the "enable SPM" instructions to avoid downloading artifacts twice 1. Added more substeps to the `Package.swift` section to clarify what content needs to be updated. 1. Clarified in which directory `flutter run` and `pod lib lint` commands should be run _PRs or commits this PR depends on (if any):_ flutter/website#10960 ## Presubmit checklist - [x] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
Fixes flutter/website#7997 I searched pub.dev, but didn't see other packages that support this. If you find any other, either file an issue or a PR to add those to the list.
Adding a note to that effect. Fixes flutter/website#8738 Co-authored-by: Brett Morgan <[email protected]>
The DevTools 2.37.1 release will be replaced by 2.37.2 due to a cherry-pick release of DevTools onto the Flutter beta branch.
…le app (#10976) If you enable SwiftPM and run an app, the app is migrated to add SwiftPM integration. To run the app if you don't have SwiftPM enabled, you either need to enable SwiftPM or remove SwiftPM integration from the app. This updates the SwiftPM plugin migration guide to recommend **not** checking-in the SwiftPM changes to the plugin's example apps. This ensures that users that don't have SwiftPM enabled can continue to run the plugin's example apps. Preview links to updated sections: 1. [How to turn on Swift Package Manager](https://flutter-docs-prod--pr10976-spm-clarify-dont-migrate-4acxxqva.web.app/packages-and-plugins/swift-package-manager/for-app-developers#how-to-turn-on-swift-package-manager) 2. [How to remove Swift Package Manager integration](https://flutter-docs-prod--pr10976-spm-clarify-dont-migrate-4acxxqva.web.app/packages-and-plugins/swift-package-manager/for-app-developers#how-to-remove-swift-package-manager-integration) 3. [How to add Swift Package Manager support to an existing Flutter plugin](https://flutter-docs-prod--pr10976-spm-clarify-dont-migrate-4acxxqva.web.app/packages-and-plugins/swift-package-manager/for-plugin-authors#how-to-add-swift-package-manager-support-to-an-existing-flutter-plugin) Part of flutter/flutter#152276 ## Presubmit checklist - [x] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
…981) Added a migration guide for a deprecation in flutter/flutter#152486. ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
This adds `TODO:` to the `Package.swift` template to make make it more obvious what you need to edit. Originally the idea was to make the code have compilation errors. I was hoping to use [compiler diagnostic directives](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0196-diagnostic-directives.md), however, Swift doesn't support putting these directives within a method call's arguments. In other words, we can't use compilation directives close enough to the places that need to be edited. Part of flutter/flutter#152276 ## Presubmit checklist - [x] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer.
As provided by @dkwingsmt. Thx! Staged here: https://flutter-docs-prod--pr10985-cupertino-xs1s2r8c.web.app/ui/widgets/cupertino
_Description of what this PR is changing or adding, and why:_ Added a missing space between `AnimationController` and `_controller` in a code example. Nothing special. _Issues fixed by this PR (if any):_ None. _PRs or commits this PR depends on (if any):_ None.
This PR: * Adds an "Embedding Flutter on the Web" documentation page describing the different ways that Flutter content can be added to a host website: full-screen, embedded mode/multiView, custom element (single-view embedded mode). * Adds a "Embedding web content into a Flutter web app" documentation page describing how to add Web content into a Flutter web app as a Widget. (Both of the pages are added under the "Platform integration > Web" section.) The PR also: * De-duplicates redundant embedding content from different pages, by linking directly to the new documents (Web FAQ, Web deployment) * Adds an "Add to a web app" link under the "Add to an existing app" menu section, pointing to the Embedding on the web, so people looking at Add To App finds the Web docs more easily. ## Issues Fixes: flutter/website#10773 ## Presubmit checklist - [ ] This PR is marked as draft with an explanation if not meant to land until a future stable release. - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
shikijs/shiki#702 has more details about the upstream deprecation and change.
This pull request replace a broken link as follows. - Before: https://mobx.netlify.com/getting-started - After: https://mobx.netlify.app/getting-started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #374