-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Reset password API documentation #3334
base: master
Are you sure you want to change the base?
Conversation
@cf-bottom jenkins |
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/fast-build-and-deploy-docs-master/607/ Documentation: http://buildcache.cfengine.com/packages/build-documentation-pr/jenkins-fast-build-and-deploy-docs-master-607/output/_site/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, if we can, remove the error codes which reveal information about user accounts existing and backoff algorithms. I understand if Mission Portal needs this information from this API, I wonder if we could limit the response codes only in the case that the request came from not localhost essentially?
36e81e3
to
c90de67
Compare
Ticket: ENT-10837 Signed-off-by: Ihor Aleksandrychiev <[email protected]>
c90de67
to
82f505c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't there generally be comments about what RBAC privileges a user needs to perform these operations?
Other than that a formatting quibble which you can take or leave. 👍
This call initiates the password reset process by sending a reset password | ||
link and token to the user's registered email address. User can click the link from the email | ||
and set a new password in the Mission Portal or invalidate the request. | ||
Every request has an expiration time equal to 48 hours. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure that for markdown we can use one-sentence-per-line which is easier to edit/manipulate/see changes.
This call initiates the password reset process by sending a reset password | |
link and token to the user's registered email address. User can click the link from the email | |
and set a new password in the Mission Portal or invalidate the request. | |
Every request has an expiration time equal to 48 hours. | |
This call initiates the password reset process by sending a reset password link and token to the user's registered email address. User can click the link from the email and set a new password in the Mission Portal or invalidate the request. | |
Every request has an expiration time equal to 48 hours. |
Ticket: ENT-10837