Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

[terra-functional-testing] Add flag to disable internal webpack server #849

Merged
merged 8 commits into from
Mar 8, 2024

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented Mar 6, 2024

Summary

This PR adds the --disable-server flag to the terra-functional-testing wdio command to disable the internal webapck server for local development. This will allow developers to use another webpack service, such as from npm start which can help speed up development if that is already running.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

This was tested by installing a local copy of terra-functional-testing with these changes in terra-framework, running npm start in a terminal and running wdio tests with the --disable-server flag in another server. The wdio service managed to connect to the external webpack server and tests were able to run successfully.

CleanShot 2024-03-06 at 14 18 30

CleanShot 2024-03-06 at 14 23 57

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details


Thank you for contributing to Terra.
@cerner/terra

@sdadn sdadn self-assigned this Mar 6, 2024
@sdadn sdadn requested a review from a team as a code owner March 6, 2024 20:42
@github-actions github-actions bot temporarily deployed to preview-pr-849 March 6, 2024 20:42 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-849 March 6, 2024 20:44 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-849 March 6, 2024 20:50 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-849 March 6, 2024 20:53 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-849 March 6, 2024 21:16 Destroyed
@kenk2
Copy link
Contributor

kenk2 commented Mar 7, 2024

I'm noticing that quite a few of the CLI params are being changed. How will this affect consumers downstream?

@sdadn
Copy link
Contributor Author

sdadn commented Mar 7, 2024

I'm noticing that quite a few of the CLI params are being changed. How will this affect consumers downstream?

This is mainly updating the documentation as kebab case is the convention for cli params. This won't affect consumers as the cli accepts both kebab case and camel case for parameters.

@sdadn sdadn merged commit 5c50a00 into main Mar 8, 2024
6 checks passed
@sdadn sdadn deleted the functional-testing-webpack-update branch March 8, 2024 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants