This repository has been archived by the owner on May 22, 2024. It is now read-only.
Added missing fibers transient dependency #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdadn
changed the title
kenk2
approved these changes
Feb 6, 2024
nikhitasharma
approved these changes
Feb 6, 2024
sycombs
approved these changes
Feb 6, 2024
|
All the tests are passing locally; the test failure is unrelated to this change.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
This PR adds the missing
fibersdependency which is a transient dependency ofwebpack-config-terrathroughsass-loader@10.Why it was changed:
Currently, the
fibersdependency was installed through@wdio/syncinterra-functional-testing, causing an indirect dependency on thatterra-functional-testingregardless of it is needed. Therefore,fiberswas explicitly added towebpack-config-terrato decouple that link and to allow for removing of@wdio/syncfor a future webdriverio upgrade.Testing
This change was tested using:
This was tested by ensuring that the local dev-site works with
npm start.Reviews
In addition to engineering reviews, this PR needs:
Additional Details
Thank you for contributing to Terra.
@cerner/terra