This repository has been archived by the owner on May 22, 2024. It is now read-only.
[package-json-lint-config-terra] upgraded to package-json-lint v2 #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenk2
approved these changes
Jan 31, 2024
|
Approved, but do we need an upgrade guide for this? |
kenk2
reviewed
Jan 31, 2024
| @@ -40,9 +40,8 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@cerner/eslint-config-terra": "^5.6.0", | |||
There was a problem hiding this comment.
tiny nit: I think CI is panicking over this dangling comma
Added here: 4479973 |
sdadn
changed the title
nikhitasharma
approved these changes
Jan 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the peerDependency for
package-json-lintinpackage-json-lint-config-terrato v2 to resolve a conflicting peer-dependency issue.Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
Thank you for contributing to Terra.
@cerner/terra