Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Add package-lock json #3951

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Add package-lock json #3951

merged 8 commits into from
Oct 26, 2023

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented Oct 26, 2023

Summary

What was changed:
This PR adds package-lock for this repo.

Why it was changed:
To have more consistency between builds. A recent sub dependency update is causing build failures (https://github.com/cerner/terra-core/actions/runs/6658607348/job/18096532087). Adding a package-lock ensure more stability in versions across builds.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

This was tested by running npm start to confirm that the project compiles and runs:

CleanShot 2023-10-26 at 17 45 12

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details


Thank you for contributing to Terra.
@cerner/terra

@sdadn sdadn self-assigned this Oct 26, 2023
@sdadn sdadn requested a review from a team as a code owner October 26, 2023 22:45
@github-actions github-actions bot temporarily deployed to preview-pr-3951 October 26, 2023 22:50 Destroyed
@sdadn
Copy link
Contributor Author

sdadn commented Oct 26, 2023

The failure is caused by linter errors, however, npm install and the deployment site work fine:

CleanShot 2023-10-26 at 18 23 28

The linter errors can be fixed in a separate PR.

@sdadn sdadn merged commit 1aa2e87 into main Oct 26, 2023
20 of 21 checks passed
@sdadn sdadn deleted the generate-package-lock branch October 26, 2023 23:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants