This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-tag] Combobox throws error when integrated with Fusion Combo Box #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Terra Form Select Combobox component tries to access a DOM element using a hardcoded classname string in method. This component works fine when consumed normally. But in fusion, the compilation step transpiles these sass classes coming from terra into some dynamic string. So, when consuming Combox in fusion, the component is not able to find the element using the logic mentioned above.
What was changed:
Added data attribute instead of querying class Name.
Why it was changed:
When Combo box is used in Mpage Application all the class names are transpiled. And when we try to query using the class name component gets crashed.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9759
Thank you for contributing to Terra.
@cerner/terra