This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-alert] Update notification banner documentation #3933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trandrew1023
commented
Oct 10, 2023
| <ActionExample title="Notification Banner with Action" /> | ||
| <DismissibleExample title="Dismissible Notification Banner" /> | ||
| <ActionAndDismissibleExample title="Dismissible Notification Banner with Actions" /> |
There was a problem hiding this comment.
Removed this since it was a bad example of a custom notification without title and there are already examples of notification with action and dismiss
trandrew1023
commented
Oct 10, 2023
| </> | ||
|
|
||
| </div> | ||
| <LiveRegionsExampleCode /> |
There was a problem hiding this comment.
Updated to toggle button to show example code rather than leaving code on page by default
artpark
approved these changes
Oct 10, 2023
sdadn
approved these changes
Oct 10, 2023
smason0
reviewed
Oct 10, 2023
packages/terra-core-docs/src/terra-dev-site/doc/alert/About.1.doc.mdx
Outdated
Show resolved
Hide resolved
smason0
reviewed
Oct 10, 2023
packages/terra-core-docs/src/terra-dev-site/doc/alert/AccessibilityGuide.2.doc.mdx
Outdated
Show resolved
Hide resolved
smason0
approved these changes
Oct 10, 2023
trandrew1023
force-pushed
the
update-alert-doc
branch
from
5c765ef to
f6e9705
Compare
chrismichalewicz
added
⭐ Accessibility Reviewed
chrismichalewicz
added
⭐ Functionally Reviewed
⭐ UX Reviewed
|
@trandrew1023 Reviewed this and it looks good functionally. There were minimal updates that required a11y review but checked the "Show live revion example code" toggle and it communicated and functioned as expected in Edge/Jaws. As the changes were minimal and provided clarity to the title prop rather than specific examples I went ahead and updated the UX label as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Why it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
UXPLATFORM-9751
Thank you for contributing to Terra.
@cerner/terra