This repository has been archived by the owner on May 24, 2024. It is now read-only.
[Terra-Icon] Added support for Decorative Icons #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdadn
added
do not merge
🚧 Blocked: Engineering Input
and removed
do not merge
🚧 Blocked: Engineering Input
labels
|
Originally marked it as blocked because I had some confusion and concerns over the passivity but those got resolved offline. |
sdadn
approved these changes
Jan 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provides support to create decorative Icons.
Deprecates prop
ariaLabel.This PR includes changes of PR:
#3598
#3604
Closes #
Deployment Link
https://terra-core-deployed-pr-#.herokuapp.com/
Testing
With Jest Test to ensure icon is decorative when value is not provided for prop
a11yLabel.Additional Details
Thank you for contributing to Terra.
@cerner/terra