This repository has been archived by the owner on May 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Backtick'd a lot of elements throughout the entire page, including some linked elements - Overview paragraph updated - Links to FHIR-controlled fields updated - Custodian link wasn't pointing to r4 specifically - adjusted - Per PR#349, the Document description/title link is no longer supported and needed removed - #349 - Added links out to the R4 Binary resource in various places, since that resource gets referred to by this one. - Search's Parameter table updated, and elements were re-orderd to put `date` and `period` next to each other - Search's Implementation notes greatly expanded, based on API behavior during testing - encounter previously - `date` and `period` specifically needed adjustments on behavior, as they were substantially lacking in detail - Per PR#959, the notes about `period` specifically were not consistent with the API's behavior - #959 - Added detail about the _id, and encounter behaviors - Adjusted the _revinclude details to mimic more recently documentation updates - Anonymized the x-ref IDs for the Create and Updated responses - Fixed Typo in the `R4_DOCUMENT_REFERENCE` example in the RUBY file - had a bonus double quote in there. - YAML file corrections - consistency around MIME vs. mime - needed to escape the hyphens in the YAML file - they were breaking the code blocking from the backticks, so we got to use HTML tags instead - fixed some "angled" doublequotes - ensured we were aiming to R4-specific resources for many links that weren't already
code element wasn't liking the parentheses around it
This was referenced Oct 9, 2023
kckeim
requested review from
gmodrogan,
AlexandruBasarab,
amcginn,
krycunn and
RicardoCrespo-ora
October 9, 2023 18:05
RicardoCrespo-ora
approved these changes
Oct 9, 2023
napster235
approved these changes
Oct 25, 2023
amcginn
reviewed
Oct 25, 2023
amcginn
reviewed
Oct 26, 2023
content/millennium/r4/foundation/documents/document-reference.md
Outdated
Show resolved
Hide resolved
amcginn
reviewed
Oct 26, 2023
amcginn
reviewed
Oct 26, 2023
@@ -295,18 +294,12 @@ Date: Fri, 04 Nov 2022 11:54:04 GMT | |||
Etag: W/"2" | |||
Last-Modified: Fri, 04 Nov 2022 11:54:04 GMT | |||
Vary: Origin | |||
X-Request-Id: d2a211a4-ccd4-4ba8-b4f4-d3da9200543c+6313_U7Z3 | |||
X-Request-Id: 1111111111111111111111111111111111111111111111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UUID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
amcginn
reviewed
Oct 26, 2023
amcginn
approved these changes
Oct 26, 2023
- Added anonymized opc-request-id's into the responses - flipped to uuid format for anonymized x-request-id's
Someshnsn
added a commit
that referenced
this pull request
Nov 10, 2023
* R4 Appointment updates (#988) * Diagnostic report r4 docs migrate (#991) * Updated DiagnosticReport DSTU2 Resource (#992) * Update DSTU 2 Appointment documentation (#993) * R4_UK_BRAM_Update_Slot_include (#994) * Reorder actions to Search, Read, Create, Patch (#995) * Review and Corrections for Condition (#996) * Update action-comment in cancellation workflow and custom encounter search (#997) * Updated DocumentReference R4 Resource (#999) * Review and updates for Location (#1001) * Diagnostic Report Create for Cardiology and Anatomic pathology (#1002) * Review and Updates for Encounter (#1007) * Review and Updates for NutritionOrder (#1008)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tons of formatting updates in this one, and substantial re-wording of sections to be more descriptive and in a similar style to other resources that were recently updated.
Verified good links through document.
Validated that API calls behave as expected with both the expected and unexpected parameters.
Description
date
andperiod
next to each otherdate
andperiod
specifically needed adjustments on behavior, as they were substantially lacking in detailperiod
specifically were not consistent with the API's behavior_id
, andencounter
behaviors_revinclude
details to mimic more recently documentation updatesR4_DOCUMENT_REFERENCE
example in the RUBY file - had a bonus double quote in there.PR Checklist
Old Overview:
New Overview:
Old Parameters table:
New Parameters table:
Old Search Implementation Notes:
New Search Implementation Notes:
Old Retrieve Implementation Notes:
New Retrieve Implementation Notes:
Old Create Implementation Notes:
New Create Implementation Notes:
Old Update Implementation Notes:
New Update Implementation Notes:
$docref old parameters and notes:
$docref new parameters and notes: