Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Review and Updates to Communication #1022

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Conversation

RicardoCrespo-ora
Copy link
Contributor

Description

In preparation for migrating to Oracle docs, we are reviewing and correcting any inconsistencies, typos, broken links, etc. This PR aims to correct any of the above that needs to be addressed within Communication and any other information directly referenced by it.

Linking to Encounter and Patient

Before
image

After
image

Capitalizacion fixes

Before
image

image image image image image

After

image image image image image

Parameters table formatting

Before
image

image

After

image

on scroll
image

image

PR Checklist

  • Screenshot(s) of changes attached before changes merged.
  • Screenshot(s) of changes attached after changes merged and published.

Copy link
Contributor

@cldeitrich cldeitrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRODOC-203712: Approved for style.

Copy link
Contributor

@kckeim kckeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This thing was in pretty good shape already, and you fixed everything that was needing addressed already.
Just a couple minor / nitpick asks from me.

* Only the body fields mentioned below are supported. Unsupported fields will be ignored.
* Modifier fields should not be provided, and will cause the transaction to fail.
* Only the body fields mentioned below are supported. Unsupported fields are ignored.
* Do not provide modifier fields because they cause the transaction to fail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer condensing this to a single line.

"Only the body fields mentioned below are supported. Unsupported fields are ignored, or can cause errors."

@amcginn amcginn added the R4 Applies to R4 FHIR resources label Dec 14, 2023
`reply-to` | [`Reference`] | Used to direct where replies to the communication should be sent. Must be a Group.
`email-status` | [`CodeableConcept`] | Status of the electronic communication (in-progress, completed, received).
`reply-to` | [`Reference`] | Directs where replies to the communication are sent. Must be a group.
`email-status` | [`CodeableConcept`] | The status of the electronic communication (in-progress, completed, or received).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget, have we been listing the required values here or in the notes section?

@RicardoCrespo-ora RicardoCrespo-ora merged commit f358185 into main Dec 15, 2023
1 check passed
@RicardoCrespo-ora RicardoCrespo-ora deleted the communication-docs-migrate branch December 15, 2023 15:21
SukeshKonjeti added a commit that referenced this pull request Feb 2, 2024
* Updated MedicationAdminstration R4 Resource (#1010)
* Updated MedicationAdministration DSTU2 Resource (#1011)
* Review and Updates to Goal (#1027)
* Review and Updates to Communication (#1022)
* dstu2 Practitioner updates (#1014)
* R4 Practitioner updates (#1015)
* Person updates for DSTU2 and R4 (#1009)
* StructureDefinition updates (#1012)
* Updated Medication Order DSTU2 Resource (#1020)
* Updated MedicationStatement DSTU2 Resource (#1021)
* Updated MedicationRequest R4 Resource (#1019)
* Updated Provenance R4 Resource (#1018)
* DSTU 2 Patient updates (#1023)
* R4 Patient formatting and standard updates (#1028)
* R4 Observation,DocumentReference Documentation Updates (#1031)
* R4 Encounter Period StartDateTime Sort Update (#1033)
* updated Location type search parameter and examples for physicalType (#1034)
* [R4][DiagnosticReport][DocumentReference] support search by _lastUpdated (#1032)
* [R4][Immunization] Support search by _lastUpdated (#1029)
* R4 Binary Autogen CCD add encounter parameter (#1035)
* [R4][Immunization] Documentation Update (#1036)
@SukeshKonjeti
Copy link
Contributor

after changes published
Screenshot 2024-02-02 at 5 25 13 PM

Screenshot 2024-02-02 at 5 25 40 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
R4 Applies to R4 FHIR resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants