hw7 #2
Open
hw7 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belou5ov
approved these changes
Apr 21, 2024
| http://localhost:8000/seldon/default/$(MODEL_NAME)/api/v1.0/predictions | ||
|
|
||
| # Display help for available Makefile commands | ||
| help: |
There was a problem hiding this comment.
Рекомендую help писать рядом с командой, а затем выводить автоматом. Отдельный хелп через какое-то время становится неактуальным. Пример https://github.com/ajbosco/dag-factory/blob/master/Makefile (показывал в прошлом семетре).
|
|
||
| # Attempt to remove the existing settings file if it exists | ||
| try: | ||
| os.remove(settings_path) |
There was a problem hiding this comment.
В pathlib можно делать файлу unlink с параметром ок, если не существует. Получается чуть удобнее.
| with open(settings_path, "w") as file: | ||
| json.dump(configuration, file, indent=4) | ||
| print(f"Model settings updated successfully in {settings_path}.") | ||
|
|
There was a problem hiding this comment.
Между функциями два пробела. Подключай форматирование с помощью black.
| ] | ||
| } | ||
|
|
||
| @pytest.mark.parametrize("endpoint", ["http://localhost:9000/v2/models/uplift-predictor/infer"]) |
There was a problem hiding this comment.
parametrize стоит использовать, если параметров больше одного.
| [dataset_bundle.data["train"], dataset_bundle.treatment, dataset_bundle.target], axis=1 | ||
| ).set_index("client_id") | ||
|
|
||
| client_features = client_info.copy() |
There was a problem hiding this comment.
Зачем копируешь датафрейм? Кажется, что дальше не используется client_info.
| cat_params = {'iterations': 20, 'random_state': 42} | ||
| if config_type == 'solo': | ||
| return SoloModel(estimator=CatBoostClassifier(**cat_params)) | ||
| else: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.