Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error on illegal page size #662

Merged
merged 7 commits into from
Jan 16, 2025
Merged

fix: error on illegal page size #662

merged 7 commits into from
Jan 16, 2025

Conversation

andrewalexander
Copy link
Contributor

@andrewalexander andrewalexander commented Oct 24, 2024

Adds an error if a page size greater than the API's maximum of 1000 is entered. It also includes a message instructing users to use --pages -1 to fetch all pages in the event they hit this error.

Updated 2025-01-10:

Updated the dependencies per all the other open dependabot PRs; added the same check/warning for the execute-saved-query-by-id variant (done before we execute the saved query); and added tests for both places to maintain 100% coverage

@harningt
Copy link
Contributor

Bet it wants you to break up that line :(

Copy link
Contributor

@harningt harningt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

poetry black censys/ made the suggested fix I presented

Co-authored-by: Thomas Harning Jr <[email protected]>
@github-actions github-actions bot added the stale label Dec 30, 2024
@github-actions github-actions bot closed this Jan 6, 2025
@andrewalexander
Copy link
Contributor Author

I think I need another test based on the 100% requirement of the last failure

FAIL Required test coverage of 100% not reached. Total coverage: 99.88%

Copy link
Member

@thehappydinoa thehappydinoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewalexander andrewalexander merged commit 6e1f301 into main Jan 16, 2025
5 checks passed
@andrewalexander andrewalexander deleted the error-page-size branch January 16, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants