-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error on illegal page size #662
Conversation
Bet it wants you to break up that line :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
poetry black censys/
made the suggested fix I presented
Co-authored-by: Thomas Harning Jr <[email protected]>
I think I need another test based on the 100% requirement of the last failure
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds an error if a page size greater than the API's maximum of 1000 is entered. It also includes a message instructing users to use
--pages -1
to fetch all pages in the event they hit this error.Updated 2025-01-10:
Updated the dependencies per all the other open dependabot PRs; added the same check/warning for the execute-saved-query-by-id variant (done before we execute the saved query); and added tests for both places to maintain 100% coverage