feat: update fonts and homepage image #1851
Conversation
…g + visuals #1848 Update index.md: Revise hero section with new text and tagline, and change image source
Addresses #1850 - Replace Ruberoid with Youth for titles - Replace Inter with Untitled Sans for body text - Update font paths and formats in style.css and config.ts - Add font-display: swap for better loading performance - Add specific font family classes for VPDoc and VPHome components Youth is now used for titles (h1-h6) and Untitled Sans for regular text, following the typography guidelines.
|
Warning Rate limit exceeded@jcstein has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 56 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request introduces comprehensive changes to the Celestia.org documentation website, focusing on font styling and homepage messaging. The modifications include updating the VitePress configuration to use new font assets, revising the CSS to incorporate new font families, and redesigning the homepage's hero section with updated text and imagery. These changes aim to refresh the visual identity and communication strategy of the website. Changes
Assessment against linked issues
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (6)
public/Blobspace.pngis excluded by!**/*.pngpublic/fonts/Ruberoid/Ruberoid-Bold.otfis excluded by!**/*.otfpublic/fonts/untitled-sans/untitled-sans-medium.woff2is excluded by!**/*.woff2public/fonts/untitled-sans/untitled-sans-regular.woff2is excluded by!**/*.woff2public/fonts/youth/Youth-Regular.woffis excluded by!**/*.woffpublic/fonts/youth/Youth-Regular.woff2is excluded by!**/*.woff2
📒 Files selected for processing (3)
.vitepress/config.ts(1 hunks).vitepress/theme/style.css(2 hunks)index.md(1 hunks)
🔇 Additional comments (3)
.vitepress/config.ts (1)
153-203: LGTM! Font loading configuration is well-structured.The font preloading configuration is correctly implemented with:
- Appropriate font type for woff2 files
- Preload directive for optimal loading performance
- Crossorigin attribute for CORS compliance
index.md (1)
8-11: LGTM! Homepage content updates are clear and aligned with objectives.The hero section changes successfully implement the new messaging direction as specified in the PR objectives.
.vitepress/theme/style.css (1)
Line range hint
119-160: LGTM! Font implementation follows best practices.The implementation:
- Defines clear font variables
- Applies fonts consistently across components
- Uses font-display: swap for optimal loading
It doesn't look like Untitled Sans worked as expected 👀
|
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.vitepress/config.ts(1 hunks).vitepress/theme/style.css(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .vitepress/config.ts
🔇 Additional comments (3)
.vitepress/theme/style.css (3)
150-160: LGTM! Font family applications are well-structured.The font family variables are consistently applied across different elements and components, maintaining a clear typography hierarchy between headings and body text.
96-96: Verify font file availability.Let's ensure all referenced font files exist in the correct locations.
Also applies to: 104-104, 112-112
✅ Verification successful
Font files are correctly placed and available.
All referenced font files exist in their expected locations under the
public/fonts/directory.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if all font files exist in the correct locations # List of font files to check fonts=( "public/fonts/untitled-sans/untitled-sans-regular.woff2" "public/fonts/untitled-sans/untitled-sans-medium.woff2" "public/fonts/youth/Youth-Regular.woff2" ) # Check each font file for font in "${fonts[@]}"; do if [ -f "$font" ]; then echo "✓ Found: $font" else echo "✗ Missing: $font" fi doneLength of output: 811
95-115:⚠️ Potential issueFix font family name and path inconsistencies.
There are naming inconsistencies that will cause font loading issues:
- Font family name has a typo: "Unititled-Sans" should be "Untitled-Sans"
- Medium font path has a typo: "unititled-sans" should be "untitled-sans"
These issues likely explain the font rendering problems reported in PR comments.
Apply these fixes:
- font-family: "Unititled-Sans"; + font-family: "Untitled-Sans"; src: url("/fonts/untitled-sans/untitled-sans-regular.woff2") format("woff2"); - font-family: "Unititled-Sans"; - src: url("/fonts/unititled-sans/untitled-sans-medium.woff2") format("woff2"); + font-family: "Untitled-Sans"; + src: url("/fonts/untitled-sans/untitled-sans-medium.woff2") format("woff2");Likely invalid or redundant comment.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
gottem
|
Description
This PR includes two updates to the docs site:
Updates typography to match brand guidelines
Updates homepage messaging and visuals
Related Issues
Testing
Summary by CodeRabbit
Summary by CodeRabbit
Release Notes
New Features
Style
Documentation
The release focuses on modernizing the site's typography and visual identity, providing a more contemporary and assertive presentation of the platform.