Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Directory module's functions into class #713

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

gcharest
Copy link
Contributor

Summary | Résumé

Summary | Résumé

Refactored the Google Next Directory module as a helper class.

  • Google Directory is now a class
  • State is preserved so the authenticated service can be created once and used multiple times before being closed
  • Clarified use of these helper classes: the hoisted methods make it easy to use through the code base but it is possible to simply use the Service's get_google_service and use the regular approach described in the documentation

@gcharest gcharest requested a review from a team January 15, 2025 16:02
@gcharest gcharest self-assigned this Jan 15, 2025
@gcharest gcharest enabled auto-merge (squash) January 15, 2025 18:12
@gcharest gcharest merged commit 5592c7a into main Jan 15, 2025
8 checks passed
@gcharest gcharest deleted the refactor/gnext_directory branch January 15, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants