updating upload artifact (#2411)

* updating upload artifact * udpating docker tag
cds-snc · Jan 9, 2025 · 80f42e8 · 80f42e8
1 parent a3b1835
commit 80f42e8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/docker.yaml b/.github/workflows/docker.yaml
@@ -111,14 +111,14 @@ jobs:
       env:
         GITHUB_SHA: ${{ github.sha }}
       run: |
-        echo "DOCKER_TAG=${GITHUB_SHA::7}" >> $GITHUB_ENV
+        DOCKER_TAG=${GITHUB_SHA::7}
         curl -L \
         -X POST \
           -H "Accept: application/vnd.github+json" \
           -H "Authorization: Bearer ${{ secrets.MANIFESTS_WORKFLOW_TOKEN }}" \
           -H "X-GitHub-Api-Version: 2022-11-28" \
           https://api.github.com/repos/cds-snc/notification-manifests/dispatches \
-          -d '{"event_type":"update-docker-image","client_payload":{"component":"API","docker_tag":"${{ env.DOCKER_TAG }}"}}'
+          -d '{"event_type":"update-docker-image","client_payload":{"component":"API","docker_tag":"$DOCKER_TAG"}}'
 
     - name: my-app-install token
       id: notify-pr-bot

diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -45,7 +45,7 @@ jobs:
       run: poetry run make test
     - name: Upload pytest logs on failure
       if: ${{ failure() }}
-      uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
+      uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0
       with:
         name: pytest-logs
         path: |