Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDAP-21099] Implement ErrorClassification API for program runs #15774

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

itsankit-google
Copy link
Member

@itsankit-google itsankit-google commented Dec 18, 2024

Jira : CDAP-21099

Description

This PR adds support for error classification API for program runs based on ProgramFailureException thrown from different stages.

Unit Tests

Added ErrorLogsClassifierTest.java

Tested in CDAP Sandbox

image

@itsankit-google itsankit-google force-pushed the CDAP-21099 branch 5 times, most recently from 2245c19 to 6927caf Compare December 18, 2024 13:14
@itsankit-google itsankit-google added the build Triggers github actions build label Dec 18, 2024
@itsankit-google itsankit-google requested a review from tivv December 18, 2024 13:15
Copy link
Contributor

@tivv tivv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add unit tests

@itsankit-google itsankit-google force-pushed the CDAP-21099 branch 3 times, most recently from ed4ac6d to 203c62f Compare December 19, 2024 09:57
@itsankit-google itsankit-google requested a review from tivv December 19, 2024 09:59
@itsankit-google itsankit-google force-pushed the CDAP-21099 branch 2 times, most recently from bd00535 to c403a41 Compare December 19, 2024 12:57
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
68.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@itsankit-google itsankit-google merged commit 61fdc98 into develop Dec 20, 2024
9 of 10 checks passed
@itsankit-google itsankit-google deleted the CDAP-21099 branch December 20, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Triggers github actions build error-management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants