-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CDAP-21099] Implement ErrorClassification API for program runs #15774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsankit-google
force-pushed
the
CDAP-21099
branch
5 times, most recently
from
December 18, 2024 13:14
2245c19
to
6927caf
Compare
tivv
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add unit tests
cdap-proto/src/main/java/io/cdap/cdap/proto/ErrorClassificationResponse.java
Show resolved
Hide resolved
cdap-proto/src/main/java/io/cdap/cdap/proto/ErrorClassificationResponse.java
Outdated
Show resolved
Hide resolved
cdap-watchdog/src/main/java/io/cdap/cdap/logging/ErrorLogsClassifier.java
Show resolved
Hide resolved
cdap-watchdog/src/main/java/io/cdap/cdap/logging/gateway/handlers/LogHttpHandler.java
Outdated
Show resolved
Hide resolved
cdap-watchdog/src/main/java/io/cdap/cdap/logging/ErrorLogsClassifier.java
Show resolved
Hide resolved
cdap-watchdog/src/main/java/io/cdap/cdap/logging/gateway/handlers/LogHttpHandler.java
Outdated
Show resolved
Hide resolved
cdap-watchdog/src/main/java/io/cdap/cdap/logging/gateway/handlers/LogHttpHandler.java
Outdated
Show resolved
Hide resolved
itsankit-google
force-pushed
the
CDAP-21099
branch
3 times, most recently
from
December 19, 2024 09:57
ed4ac6d
to
203c62f
Compare
itsankit-google
force-pushed
the
CDAP-21099
branch
2 times, most recently
from
December 19, 2024 12:57
bd00535
to
c403a41
Compare
Quality Gate failedFailed conditions |
itsankit-google
force-pushed
the
CDAP-21099
branch
from
December 19, 2024 18:02
c403a41
to
4e18685
Compare
itsankit-google
force-pushed
the
CDAP-21099
branch
from
December 19, 2024 18:03
4e18685
to
bd97ede
Compare
tivv
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira : CDAP-21099
Description
This PR adds support for error classification API for program runs based on ProgramFailureException thrown from different stages.
Unit Tests
Added
ErrorLogsClassifierTest.java
Tested in CDAP Sandbox