[CDAP-21089] OAuthHandler should not return 5xx on 4xx errors to skip retries and throw errors for invalid macros based on stage validation request. #15758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikasrathee-cs
force-pushed
the
oauth-macro-issue
branch
2 times, most recently
from
5623990 to
04bf38c
Compare
vikasrathee-cs
changed the title
...data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/service/RemoteValidationTask.java
Outdated
Show resolved
Hide resolved
...ap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/service/ValidationHandler.java
Outdated
Show resolved
Hide resolved
vikasrathee-cs
force-pushed
the
oauth-macro-issue
branch
from
04bf38c to
faa037d
Compare
...cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineServiceTest.java
Show resolved
Hide resolved
...ap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/service/ValidationHandler.java
Outdated
Show resolved
Hide resolved
...cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineServiceTest.java
Outdated
Show resolved
Hide resolved
...dap-etl-proto/src/main/java/io/cdap/cdap/etl/proto/v2/validation/StageValidationRequest.java
Show resolved
Hide resolved
...dap-etl-proto/src/main/java/io/cdap/cdap/etl/proto/v2/validation/StageValidationRequest.java
Show resolved
Hide resolved
vikasrathee-cs
force-pushed
the
oauth-macro-issue
branch
2 times, most recently
from
6954d43 to
0c6c1f3
Compare
vikasrathee-cs
changed the title
vikasrathee-cs
force-pushed
the
oauth-macro-issue
branch
from
0c6c1f3 to
79ff250
Compare
...cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineServiceTest.java
Outdated
Show resolved
Hide resolved
...cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineServiceTest.java
Outdated
Show resolved
Hide resolved
...cdap-data-pipeline-base/src/test/java/io/cdap/cdap/datapipeline/DataPipelineServiceTest.java
Outdated
Show resolved
Hide resolved
vikasrathee-cs
force-pushed
the
oauth-macro-issue
branch
from
79ff250 to
6cf161b
Compare
…throw error in case of invalid oauth macro.
vikasrathee-cs
force-pushed
the
oauth-macro-issue
branch
from
6cf161b to
1af2783
Compare
itsankit-google
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDAP-21089 OAuthHandler should not return 5xx on 4xx errors to skip retries. Also added a doNotSkipInvalidMacroForFunctions in StageValidationRequest method to throw error in case provided macros are invalid.
can be used like
namespaces/system/apps/pipeline/services/studio/methods/v1/contexts/default/validations/stage?doNotSkipInvalidMacroForFunctions=oauthAccessToken,oauthBefore Adding doNotSkipInvalidMacroForFunctions, it was not throwing any error
After Adding doNotSkipInvalidMacroForFunctions, it was throwing below error