Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemAdmin feature scenarios addition #15346

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

itsmekumari
Copy link
Contributor

@itsmekumari itsmekumari commented Oct 5, 2023

Few SystemAdmin feature design scenarios addition. Related framework level changes are in PR cdapio/cdap-e2e-tests#215

@itsmekumari itsmekumari marked this pull request as draft October 5, 2023 15:31
@itsankit-google itsankit-google added the build Triggers github actions build label Oct 5, 2023
@itsmekumari itsmekumari marked this pull request as ready for review October 6, 2023 11:48
@itsmekumari itsmekumari force-pushed the e2e_sysadmin branch 2 times, most recently from 2fac2df to 3cab459 Compare October 20, 2023 13:08
@itsmekumari itsmekumari force-pushed the e2e_sysadmin branch 4 times, most recently from ff14c7e to 479e615 Compare November 2, 2023 12:18
When Open "System Admin" menu
Then Click on the Configuration link on the System admin page
Then Select "systemPreferences" option from Configuration page
Then Click on edit system preferences
Copy link
Contributor

@radhikav1 radhikav1 Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you can use Background section to define common steps that are to be run for all the scenarios in the feature.
Refer https://cucumber.io/docs/gherkin/reference/#background for more details and examples

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the Background section for the common steps in features.

Copy link
Contributor

@radhikav1 radhikav1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that e2e test job on this PR runs fine with system admin helper cdapio/cdap-e2e-tests#215 changes.

@radhikav1 radhikav1 merged commit 489ba81 into cdapio:develop Jan 5, 2024
6 of 8 checks passed
@itsmekumari
Copy link
Contributor Author

Please ensure that e2e test job on this PR runs fine with system admin helper cdapio/cdap-e2e-tests#215 changes.

Yes, All the Sysadmin feature e2e tests are passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Triggers github actions build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants