-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SystemAdmin feature scenarios addition #15346
Conversation
2fac2df
to
3cab459
Compare
ff14c7e
to
479e615
Compare
When Open "System Admin" menu | ||
Then Click on the Configuration link on the System admin page | ||
Then Select "systemPreferences" option from Configuration page | ||
Then Click on edit system preferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you can use Background
section to define common steps that are to be run for all the scenarios in the feature.
Refer https://cucumber.io/docs/gherkin/reference/#background for more details and examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the Background section for the common steps in features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure that e2e test job on this PR runs fine with system admin helper cdapio/cdap-e2e-tests#215 changes.
1a8ca79
to
3c62921
Compare
61b7922
to
f359c11
Compare
ed98cac
to
25bc105
Compare
25bc105
to
1c41163
Compare
51b27e3
to
12536cb
Compare
12536cb
to
dbbae99
Compare
Yes, All the Sysadmin feature e2e tests are passed. |
Few SystemAdmin feature design scenarios addition. Related framework level changes are in PR cdapio/cdap-e2e-tests#215