Fix type of anchorEl in Popover, fixes positioning in Popover and Menu #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The anchorEl accepts a dom element, not a ref. Since it does not try to resolve the ref, the result is the same as if anchorEl would be missing. Instead it should accept a nullable dom element.
|
Hi, please check if this fix is correct, I've only started to update to Rescript 11 + Mui 5, and so far I've only tested this with a Menu manually. However from the Mui code and docs it looks to me that anchorEl - at least in Popover and Menu - does not resolve a ref, but it simply requires a dom element to be passed. |
|
You are right, the TS types also don't use a ref but just a html element here. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anchorEl accepts a dom element, not a ref. Since it does not try to resolve the ref, the result is the same as if anchorEl would be missing.
Instead it should accept a nullable dom element.