add style to live mode #1092
Merged
add style to live mode #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbedouret
requested changes
Dec 10, 2021
tomivm
force-pushed
the
feature/add-style-to-live-mode
branch
from
4053e93
to
9c89e45
Compare
|
Thanks for the review @martinbedouret . I made some changes to fix issues if 'Remove symbols from the output bar' is enabled. There is a test failing because I use CSS vars. I can't find a solution to disable that warning. It' looks like Csslint is outdated. you can see this same issue. Can you ignore the issue on Codacy? |
…into feature/add-style-to-live-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1071 close #1051