Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add build workflow #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

backwardspy
Copy link
Member

this PR covers building the extension & uploading the artifact. it does not cover bumping the version number or creating a release automatically.

i think we should consider release-please for those latter two operations.

@backwardspy backwardspy requested a review from sgoudham December 7, 2024 12:11
@backwardspy backwardspy self-assigned this Dec 7, 2024
Copy link
Contributor

@djflan djflan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. could probably add a gh action to increment the vsix manifest

@sgoudham
Copy link
Contributor

sgoudham commented Dec 9, 2024

nice. could probably add a gh action to increment the vsix manifest

Yup, release please can handle this for us.

I'll assign it to myself to implement release please with the build.yml you've proven out here. Thanks @backwardspy!

@sgoudham sgoudham assigned sgoudham and unassigned backwardspy Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants